-
-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: Add test for valid non-string input #463
Conversation
Hi @stonegray!, thanks for the Pull Request The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.
Read more about contributing to ESLint here |
Hi @stonegray!, thanks for the Pull Request The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.
Read more about contributing to ESLint here |
Wow, recursive |
I don’t think we need to make any changes, I’m fine with just adding the test. |
Yeah , adding this test seems fine. additionally if we want to inform users, then we can add a note in docs saying its recommended to use string as inputs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems we're in agreement. Thanks @stonegray! LGTM.
Test that buffers and strings produce equal output to resolve uncovered line.