Skip to content
This repository has been archived by the owner on Aug 20, 2024. It is now read-only.

fix: remove useless sourcemap url (#43) #44

Merged
merged 1 commit into from
Mar 23, 2023
Merged

fix: remove useless sourcemap url (#43) #44

merged 1 commit into from
Mar 23, 2023

Conversation

tjx666
Copy link
Contributor

@tjx666 tjx666 commented Mar 22, 2023

No description provided.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 22, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: tjx666 / name: 余腾靖 (90b23ec)

@tjx666 tjx666 mentioned this pull request Mar 22, 2023
Closed
mdjermanovic
mdjermanovic reviewed Mar 22, 2023
View reviewed changes
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM. Can you sign the CLA so we could merge this?

@mdjermanovic mdjermanovic linked an issue Mar 22, 2023 that may be closed by this pull request
remove the sourcemap url #43
Closed
@mdjermanovic
Copy link
Member

I can see on eslint/js#567 that the CLA is signed, but here the check says that it still isn't. I'll try close/reopen to update the check.

@mdjermanovic mdjermanovic reopened this Mar 23, 2023
@mdjermanovic
Copy link
Member

Close/reopen worked, all green now.

mdjermanovic
mdjermanovic approved these changes Mar 23, 2023
View reviewed changes
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! I'm leaving this open for a couple of days in case someone else wants to take a look

nzakas
nzakas approved these changes Mar 23, 2023
View reviewed changes
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nzakas nzakas merged commit e9a070f into eslint:main Mar 23, 2023
@data-sync-user data-sync-user mentioned this pull request Oct 12, 2023
Merged
@julitabarelkowska julitabarelkowska mentioned this pull request May 30, 2024
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mdjermanovic mdjermanovic mdjermanovic approved these changes

@nzakas nzakas nzakas approved these changes

Assignees
No one assigned
Labels
accepted bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove the sourcemap url
3 participants
@tjx666 @mdjermanovic @nzakas