#586 add hoisting check to no-unreachable #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return isAllowed; | ||
| } | ||
|
|
||
| function checkNodeFieldForUnreachable(node, field) { |
There was a problem hiding this comment.
Nice, I like this abstraction. Can you add some doc comments to it?
|
Can you also add some details in the rule documentation explaining this case? |
|
I added a note that describes the cases that don't trigger the |
| * @param {ASTNode} node | ||
| * @returns {boolean} if the node doesn't trigger unreachable | ||
| */ | ||
| function isUnreachableAllowed(node) { |
There was a problem hiding this comment.
The control flow in this function is beyond odd. Use this instead:
function isUnreachableAllowed(node) {
return node.type === "FunctionDeclaration" ||
node.type === "VariableDeclaration" &&
node.declarations.every(function(declaration){
return declaration.type === "VariableDeclarator" && declaration.init === null;
});
}--cyclomaticComplexity;
|
Thanks for the fast turnaround on the review comments! |
nzakas
added a commit
that referenced
this pull request
Feb 5, 2014
add hoisting check to no-unreachable (fixes #586)
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added check for no-unreachable if node has:
node.typeequalsFunctionDeclarationnode.typeequalsVariableDeclarationand every declaration has no initI also added some tests that verify the new implementation and refactored the initial loop to a function to avoid repetition. This pull request should resolve #586
If there's anything wrong feel free to tell me.