-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update docs and description
of require-unicode-regexp
#19205
Merged
mdjermanovic
merged 8 commits into
eslint:main
from
lumirlumir:docs-update-docs-and-description-of-require-unicode-regexp
Dec 3, 2024
Merged
docs: update docs and description
of require-unicode-regexp
#19205
mdjermanovic
merged 8 commits into
eslint:main
from
lumirlumir:docs-update-docs-and-description-of-require-unicode-regexp
Dec 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for docs-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mdjermanovic
reviewed
Dec 3, 2024
Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
…exp' of https://github.com/lumirlumir/fork-eslint into docs-update-docs-and-description-of-require-unicode-regexp
@mdjermanovic Thanks for the review! I've updated code based on your feedback. |
mdjermanovic
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
lumirlumir
deleted the
docs-update-docs-and-description-of-require-unicode-regexp
branch
December 3, 2024 13:51
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[X] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Hello,
I've made the following updates to
require-unicode-regexp.js
andrequire-unicode-regexp.md
:Added missing backticks to
RegExp
:RegExp
is wrapped in backticks, but it was missing here.Aligned
@fileoverview
with thedescription
:@fileoverview
comment didn’t match thedescription
, so I made them consistent.Is there anything you'd like reviewers to focus on?
Nothing.