fix: Bring types in sync with @eslint/core #19157
Conversation
✅ Deploy Preview for docs-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -468,7 +468,7 @@ rule = { | |||
| context.markVariableAsUsed("foo"); | |||
|
|
|||
| context.report({ message: "foo", node: AST }); | |||
| context.report({ message: "foo", loc: { line: 0, column: 0 } }); | |||
| context.report({ message: "foo", loc: { start: {line: 0, column: 0}, end: { line: 1, column: 1 } } }); | |||
There was a problem hiding this comment.
This appeared to be an error in the current types, as loc should have start and end properties.
|
Hi everyone, it looks like we lost track of this pull request. Please review and see what the next steps are. This pull request will auto-close in 7 days without an update. |
|
Not stale. We need to update |
|
I think we need one more change to full update the types in the |
|
Hi everyone, it looks like we lost track of this pull request. Please review and see what the next steps are. This pull request will auto-close in 7 days without an update. |
|
Note stale - waiting on |
|
Hi everyone, it looks like we lost track of this pull request. Please review and see what the next steps are. This pull request will auto-close in 7 days without an update. |
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:
Types update.
What changes did you make? (Give an overview)
This PR reformulates some types exported by
eslintin terms of the types exported from@eslint/core. This will allow better compatibility with language plugins and allow us to start de-duplicating types.Is there anything you'd like reviewers to focus on?
I did my best to ensure that these type changes are backwards compatible, but please do double-check:
RuleContextRuleModuleSourceCodeI also did not update
ESLint.PluginbecauseRuleDefinitioncurrently requires a parameter, but it should be optional. I need to update that in@eslint/corefirst.