Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Don't crash when directory is deleted during traversal. #19067

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented Oct 28, 2024

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Upgraded @humanfs/node to the latest version, which is able to recover from deleted directories during walk().

fixes #18955

Is there anything you'd like reviewers to focus on?

@nzakas nzakas requested a review from a team as a code owner October 28, 2024 14:00
@eslint-github-bot eslint-github-bot bot added the bug ESLint is working incorrectly label Oct 28, 2024
Copy link

netlify bot commented Oct 28, 2024

Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit cbee428
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/671f9902726b1800087f2ec0

@fasttime fasttime added the accepted There is consensus among the team that this change meets the criteria for inclusion label Oct 29, 2024
Copy link
Member

@fasttime fasttime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fasttime fasttime merged commit b442067 into main Oct 29, 2024
26 checks passed
@fasttime fasttime deleted the issue18955 branch October 29, 2024 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion bug ESLint is working incorrectly
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

Bug: ESLint can crash when a source directory is deleted while it runs
2 participants