fix: do not throw when defining a global named __defineSetter__
#18898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It replaced {} with `Object.create(null)` to avoid accessing
properties on the Object prototype.
fixes #18363
✅ Deploy Preview for docs-eslint ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
fasttime
added
core
Vylpes
pushed a commit
to Vylpes/card-drop
that referenced
this pull request
Sep 23, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [eslint](https://eslint.org) ([source](https://github.com/eslint/eslint)) | devDependencies | patch | [`8.57.0` -> `8.57.1`](https://renovatebot.com/diffs/npm/eslint/8.57.0/8.57.1) | --- ### Release Notes <details> <summary>eslint/eslint (eslint)</summary> ### [`v8.57.1`](https://github.com/eslint/eslint/releases/tag/v8.57.1) [Compare Source](eslint/eslint@v8.57.0...v8.57.1) #### Bug Fixes - [`a19072f`](eslint/eslint@a19072f) fix: add logic to handle fixTypes in the lintText() method ([#​18900](eslint/eslint#18900)) (Francesco Trotta) - [`04c7188`](eslint/eslint@04c7188) fix: Don't lint same file multiple times ([#​18899](eslint/eslint#18899)) (Francesco Trotta) - [`87ec3c4`](eslint/eslint@87ec3c4) fix: do not throw when defining a global named `__defineSetter__` ([#​18898](eslint/eslint#18898)) (Francesco Trotta) - [`60a1267`](eslint/eslint@60a1267) fix: Provide helpful error message for nullish configs ([#​18889](eslint/eslint#18889)) (Milos Djermanovic) - [`a0dea8e`](eslint/eslint@a0dea8e) fix: allow `name` in global ignores, fix `--no-ignore` for non-global ([#​18875](eslint/eslint#18875)) (Milos Djermanovic) - [`3836bb4`](eslint/eslint@3836bb4) fix: do not crash on error in `fs.walk` filter ([#​18886](eslint/eslint#18886)) (Milos Djermanovic) - [`2dec349`](eslint/eslint@2dec349) fix: skip processor code blocks that match only universal patterns ([#​18880](eslint/eslint#18880)) (Milos Djermanovic) #### Documentation - [`6a5add4`](eslint/eslint@6a5add4) docs: v8.x Add EOL banner ([#​18744](eslint/eslint#18744)) (Amaresh S M) - [`b034575`](eslint/eslint@b034575) docs: v8.x add version support page to the dropdown ([#​18731](eslint/eslint#18731)) (Amaresh S M) - [`760ef7d`](eslint/eslint@760ef7d) docs: v8.x add version support page in the side navbar ([#​18740](eslint/eslint#18740)) (Amaresh S M) - [`428b7ea`](eslint/eslint@428b7ea) docs: Add Powered by Algolia label to the search ([#​18658](eslint/eslint#18658)) (Amaresh S M) - [`c68c07f`](eslint/eslint@c68c07f) docs: version selectors synchronization ([#​18265](eslint/eslint#18265)) (Milos Djermanovic) #### Build Related - [`35d366a`](eslint/eslint@35d366a) build: Support updates to previous major versions ([#​18870](eslint/eslint#18870)) (Milos Djermanovic) #### Chores - [`140ec45`](eslint/eslint@140ec45) chore: upgrade [@​eslint/js](https://github.com/eslint/js)[@​8](https://github.com/8).57.1 ([#​18913](eslint/eslint#18913)) (Milos Djermanovic) - [`bcdfc04`](eslint/eslint@bcdfc04) chore: package.json update for [@​eslint/js](https://github.com/eslint/js) release (Jenkins) - [`3f6ce8d`](eslint/eslint@3f6ce8d) chore: pin vite-plugin-commonjs@0.10.1 ([#​18910](eslint/eslint#18910)) (Milos Djermanovic) - [`9f07549`](eslint/eslint@9f07549) chore: ignore `/docs/v8.x` in link checker ([#​18660](eslint/eslint#18660)) (Milos Djermanovic) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC44MC4wIiwidXBkYXRlZEluVmVyIjoiMzguODAuMCIsInRhcmdldEJyYW5jaCI6ImRldmVsb3AiLCJsYWJlbHMiOlsidHlwZS9kZXBlbmRlbmNpZXMiXX0=--> Reviewed-on: https://git.vylpes.xyz/External/card-drop/pulls/366 Reviewed-by: Vylpes <ethan@vylpes.com> Co-authored-by: Renovate Bot <renovate@vylpes.com> Co-committed-by: Renovate Bot <renovate@vylpes.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[X] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
Fixes #18363 on the v8.x-dev branch
What changes did you make? (Give an overview)
Applied commit eeec413 to the v8.x-dev branch.
Is there anything you'd like reviewers to focus on?