Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow escaping characters in config patterns on Windows #18628

Merged
merged 2 commits into from
Jun 27, 2024
Merged

Conversation

mdjermanovic
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

Fixes #18597

What changes did you make? (Give an overview)

Updated @eslint/config-array dependency to include the fix for this problem (eslint/rewrite#61) and added a test.

Is there anything you'd like reviewers to focus on?

@mdjermanovic mdjermanovic requested a review from a team as a code owner June 26, 2024 17:01
@eslint-github-bot eslint-github-bot bot added the bug ESLint is working incorrectly label Jun 26, 2024
Copy link

netlify bot commented Jun 26, 2024

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit 4aef042
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/667daf2c28926a00086aef5b
😎 Deploy Preview https://deploy-preview-18628--docs-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mdjermanovic mdjermanovic added core Relates to ESLint's core APIs and features accepted There is consensus among the team that this change meets the criteria for inclusion labels Jun 26, 2024
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth giving the files in curly-files different content to ensure things are working as expected?

@github-actions github-actions bot removed the core Relates to ESLint's core APIs and features label Jun 27, 2024
@mdjermanovic
Copy link
Member Author

Is it worth giving the files in curly-files different content to ensure things are working as expected?

Updated in 4aef042.

Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nzakas nzakas merged commit 1613e2e into main Jun 27, 2024
19 checks passed
@nzakas nzakas deleted the issue18597 branch June 27, 2024 20:37
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Dec 25, 2024
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Dec 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Bug: Escaping in config patterns doesn't work on Windows
2 participants