refactor: fix disable directives for languages with 0-based lines #18605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docs-eslint canceled.
|
mdjermanovic
force-pushed
the
languages-disable-directives
branch
from
f4c1c73 to
d98b508
Compare
nzakas
reviewed
Jun 19, 2024
Co-authored-by: Nicholas C. Zakas <nicholas@humanwhocodes.com>
This was referenced Jul 19, 2024
This was referenced Aug 22, 2024
This was referenced Sep 3, 2024
This was referenced Sep 14, 2024
This was referenced Sep 23, 2024
This was referenced Sep 29, 2024
This was referenced Oct 2, 2024
eslint-github-bot
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
Follow-up to #18448 (review). This fixes the behavior of disable directives when language has 0-based lines.
For example, this directive was disabling problem on line 1 instead of its own line 2:
What changes did you make? (Give an overview)
Since apply-disable-directives works with lint messages that have already been translated into messages with 1-based locations, I updated disable directive objects to be translated to 1-based locations as well, in order to properly match with lint messages.
Is there anything you'd like reviewers to focus on?
This fixes a bug, but I tagged it as "refactor" because language plugins are not an officially available feature yet.