Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Update getting-started.md - add pnpm to init eslint config #18599

Merged
merged 1 commit into from
Jun 24, 2024
Merged

docs: Update getting-started.md - add pnpm to init eslint config #18599

merged 1 commit into from
Jun 24, 2024

Conversation

KostiantynO
Copy link
Contributor

@KostiantynO KostiantynO commented Jun 18, 2024 •
edited
Loading

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[X] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Add pnpm option to init eslint config, so it can be easily searched from google to eslint install page

Is there anything you'd like reviewers to focus on?

It is simple docs update for usablity.

@KostiantynO KostiantynO requested a review from a team as a code owner June 18, 2024 02:57
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Jun 18, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: KostiantynO / name: Kostiantyn Ochenash (70162a0)

@eslint-github-bot
Copy link

Hi @KostiantynO!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.

  • The commit message tag wasn't recognized. Did you mean "docs", "fix", or "feat"?
  • There should be a space following the initial tag and colon, for example 'feat: Message'.
  • The first letter of the tag should be in lowercase

To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page.

Read more about contributing to ESLint here

1 similar comment
@eslint-github-bot
Copy link

Hi @KostiantynO!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.

  • The commit message tag wasn't recognized. Did you mean "docs", "fix", or "feat"?
  • There should be a space following the initial tag and colon, for example 'feat: Message'.
  • The first letter of the tag should be in lowercase

To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page.

Read more about contributing to ESLint here

@netlify Netlify
Copy link

netlify bot commented Jun 18, 2024 •
edited
Loading

✅ Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit 70162a0
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/6678d966fded3200083eb247

@eslint-github-bot
Copy link

Hi @KostiantynO!, thanks for the Pull Request

The pull request title isn't properly formatted. We ask that you update the pull request title to match this format, as we use it to generate changelogs and automate releases.

  • The commit message tag wasn't recognized. Did you mean "docs", "fix", or "feat"?
  • There should be a space following the initial tag and colon, for example 'feat: Message'.
  • The first letter of the tag should be in lowercase

To Fix: You can fix this problem by clicking 'Edit' next to the pull request title at the top of this page.

Read more about contributing to ESLint here

@KostiantynO KostiantynO changed the title Update getting-started.md - add pnpm to init eslint config docs: Update getting-started.md - add pnpm to init eslint config Jun 18, 2024
@eslint-github-bot eslint-github-bot bot added the documentation Relates to ESLint's documentation label Jun 18, 2024
@aladdin-add
Copy link
Member

@KostiantynO, can you sign the cla please, thanks!

@KostiantynO
Copy link
Contributor Author

@KostiantynO, can you sign the cla please, thanks!

Signed!

aladdin-add
aladdin-add approved these changes Jun 24, 2024
View reviewed changes
Copy link
Member

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would like another review before merging.

@nzakas nzakas merged commit 375227f into eslint:main Jun 24, 2024
20 checks passed
@KostiantynO KostiantynO deleted the patch-1 branch June 26, 2024 15:29
@ekmixon ekmixon mentioned this pull request Jul 19, 2024
Open
This was referenced Jul 19, 2024
Merged
Open
@jamesleesaunders jamesleesaunders mentioned this pull request Jul 20, 2024
Merged
@lholmquist lholmquist mentioned this pull request Jul 20, 2024
Closed
@saidsef saidsef mentioned this pull request Jul 20, 2024
Closed
@drwho725 drwho725 mentioned this pull request Jul 20, 2024
Merged
@leoo1992 leoo1992 mentioned this pull request Jul 20, 2024
Merged
@hizumiaoba hizumiaoba mentioned this pull request Jul 20, 2024
Merged
@jadsongmatos jadsongmatos mentioned this pull request Jul 20, 2024
Merged
@junsulee junsulee mentioned this pull request Jul 20, 2024
Open
This was referenced Jul 24, 2024
Closed
Closed
This was referenced Aug 22, 2024
Closed
Closed
@jamesleesaunders jamesleesaunders mentioned this pull request Aug 28, 2024
Closed
@lholmquist lholmquist mentioned this pull request Aug 31, 2024
Closed
@ekmixon ekmixon mentioned this pull request Aug 31, 2024
Open
This was referenced Sep 3, 2024
Closed
Closed
@zntb zntb mentioned this pull request Sep 6, 2024
Merged
This was referenced Sep 6, 2024
Open
Open
Open
This was referenced Sep 14, 2024
Closed
Closed
Closed
Closed
@vinitkumar vinitkumar mentioned this pull request Sep 18, 2024
Merged
@lholmquist lholmquist mentioned this pull request Sep 19, 2024
Closed
This was referenced Sep 23, 2024
Open
Open
@lholmquist lholmquist mentioned this pull request Sep 28, 2024
Closed
This was referenced Sep 29, 2024
Merged
Closed
@lholmquist lholmquist mentioned this pull request Oct 1, 2024
Closed
@tygyh tygyh mentioned this pull request Oct 2, 2024
Closed
This was referenced Oct 2, 2024
Closed
Closed
@ebiz-markusrissmann ebiz-markusrissmann mentioned this pull request Oct 4, 2024
Open
@lholmquist lholmquist mentioned this pull request Oct 5, 2024
Closed
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Dec 22, 2024
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Dec 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nzakas nzakas

@aladdin-add aladdin-add

Assignees
No one assigned
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation
Projects
Triage
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KostiantynO @aladdin-add @nzakas