Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update knip (with webdriver-io plugin) #18594

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

webpro
Copy link
Contributor

@webpro webpro commented Jun 17, 2024

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

Upgrade Knip, it finally has a webdriver-io plugin so we can trim .knip.jsonc a bit.

What changes did you make? (Give an overview)

Removed wdio/globals as that seems unused (browser tests still pass).

From node Makefile.js wdio or getBinFile("wdio") Knip can't derive wdio is a dependency, so unfortunately @wdio/cli had be added to ignoreDependencies.

Is there anything you'd like reviewers to focus on?

N/A

Sorry, something went wrong.

@webpro webpro requested a review from a team as a code owner June 17, 2024 14:06
@eslint-github-bot eslint-github-bot bot added the chore This change is not user-facing label Jun 17, 2024
Copy link

netlify bot commented Jun 17, 2024

Deploy Preview for docs-eslint canceled.

Name Link
🔨 Latest commit 07f3500
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/667042f74600f200084ef4a6

@mdjermanovic mdjermanovic added the accepted There is consensus among the team that this change meets the criteria for inclusion label Jun 17, 2024
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Leaving open if anyone else would like to take a look.

@mdjermanovic mdjermanovic merged commit d0c3a32 into eslint:main Jun 18, 2024
19 checks passed
@webpro webpro deleted the upgrade-knip-webdriver-io branch June 18, 2024 07:06
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Dec 16, 2024
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Dec 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion chore This change is not user-facing
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants