chore: remove `.eslintrc.js` #18011

aladdin-add · 2024-01-19T06:51:36Z

note: it's not to remove eslintrc support.

Prerequisites checklist

I have read the contributing guidelines.

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain:

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

.eslintignore was not removed, as it was used in a test:

eslint/tests/lib/cli-engine/file-enumerator.js

Lines 459 to 467 in 38b9b06

    
           it("should throw an error if no files match a glob", () => { 
        
               // Relying here on the .eslintignore from the repo root 
        
               const patterns = ["tests/fixtures/glob-util/ignored/**/*.js"]; 
        
               assert.throws(() => { 
        
                   listFiles(patterns); 
        
               }, `All files matched by '${patterns[0]}' are ignored.`); 
        
           });

do we need to add .vscode (as the flat config not enabled by default in vscode-eslint)?

netlify · 2024-01-19T06:51:42Z

✅ Deploy Preview for docs-eslint canceled.

Name	Link
🔨 Latest commit	`4c4598f`
🔍 Latest deploy log	https://app.netlify.com/sites/docs-eslint/deploys/6670f29f7446690008284983

nzakas · 2024-01-22T18:29:03Z

Can you update the description of this PR with an explanation of what changes you made? It's not clear from the title what the intent of this PR is.

aladdin-add · 2024-01-23T06:01:26Z

The ESLint repository currently contains two ESLint configurations: eslint.config.js (used by npm run lint) and .eslintrc.js (used by vscode-eslint). With the recent support for flat configuration in vscode-eslint, you can enable it by setting "eslint.experimental.useFlatConfig": true. Therefore, this pr removes '.eslintrc.js' and adds the configuration for vscode-eslint.

aladdin-add · 2024-01-23T06:10:51Z

Coverting to a draft, as I think it's better to refactor the test to not relying on the.eslintignore in root dir.

mdjermanovic · 2024-01-23T07:41:51Z

Coverting to a draft, as I think it's better to refactor the test to not relying on the.eslintignore in root dir.

I think it's fine to leave .eslintignore for now. Some 150-200 tests are using this file, so we'll need to check each before removing this file.

nzakas · 2024-01-23T18:08:47Z

The ESLint repository currently contains two ESLint configurations: eslint.config.js (used by npm run lint) and .eslintrc.js (used by vscode-eslint). With the recent support for flat configuration in vscode-eslint, you can enable it by setting "eslint.experimental.useFlatConfig": true. Therefore, this pr removes '.eslintrc.js' and adds the configuration for vscode-eslint.

It seems like we're at the point where we should be pushing VS Code to enable flat config by default? Potentially by using shouldUseFlatConfig()? I'd much rather do that then start incorporating VS Code settings into the repo (which we'll need to change later).

aladdin-add · 2024-01-24T03:08:52Z

@nzakas there is a discussion: microsoft/vscode-eslint#1644

aladdin-add · 2024-01-24T03:29:39Z

I think it's fine to leave .eslintignore for now. Some 150-200 tests are using this file, so we'll need to check each before removing this file.

it seems the ci is happy when removing .eslintignore(13daf5e), am i missing something? 🤔 @mdjermanovic

mdjermanovic · 2024-01-24T14:14:35Z

it seems the ci is happy when removing .eslintignore(13daf5e), am i missing something?

A test might still be passing but not actually testing what it was intended to if the assertions aren't precise enough. Now, that might not be the case for those particular tests, but it would be good to check each at some point.

aladdin-add · 2024-01-26T02:23:20Z

well, will remove the commit.

JoshuaKGoldberg

Exciting!

JoshuaKGoldberg · 2024-02-02T17:16:15Z

.gitignore

@@ -19,7 +19,7 @@ jsdoc/
 .cache
 /packages/**/node_modules
 /tools/internal-rules/node_modules
-/.vscode
+# /.vscode


[Question] Is there any reason to keep this around? Since .vscode/settings.json is now intentional:

Suggested change

# /.vscode

JoshuaKGoldberg · 2024-02-02T17:27:59Z

.vscode/settings.json

do we need to add .vscode (as the flat config not enabled by default in vscode-eslint)?

Linking for reference: microsoft/vscode-eslint#1644

Looks like, yes for now?

I'd still rather wait so we don't have to do this.
#18075

github-actions · 2024-02-14T22:31:15Z

Hi everyone, it looks like we lost track of this pull request. Please review and see what the next steps are. This pull request will auto-close in 7 days without an update.

Rec0iL99 · 2024-02-15T04:02:46Z

Not stale. Waiting for #18075 to resolve.

#18011 (comment) for reference.

eslint-github-bot bot added the chore label Jan 19, 2024

aladdin-add marked this pull request as ready for review January 22, 2024 02:24

aladdin-add requested a review from a team as a code owner January 22, 2024 02:24

aladdin-add marked this pull request as draft January 23, 2024 06:08

mdjermanovic mentioned this pull request Jan 23, 2024

chore: Introduce Knip #18005

Merged

1 task

aladdin-add force-pushed the chore/rm-eslintrc branch from 02146c2 to 9eb3b14 Compare January 23, 2024 10:58

snitin315 marked this pull request as ready for review January 23, 2024 12:05

aladdin-add force-pushed the chore/rm-eslintrc branch from 13daf5e to 9eb3b14 Compare January 26, 2024 05:51

aladdin-add changed the title ~~chore: remove eslintrc in eslint repo~~ chore: remove .eslintrc.js in eslint repo Jan 26, 2024

aladdin-add changed the title ~~chore: remove .eslintrc.js in eslint repo~~ chore: remove .eslintrc.js Jan 26, 2024

JoshuaKGoldberg previously approved these changes Feb 2, 2024

View reviewed changes

aladdin-add marked this pull request as draft February 4, 2024 10:08

github-actions bot added the Stale label Feb 14, 2024

Tanujkanti4441 removed the Stale label Feb 15, 2024

Tanujkanti4441 assigned aladdin-add Feb 15, 2024

aladdin-add mentioned this pull request Apr 11, 2024

chore: eslint-plugin-n v17.0.0 #18315

Merged

1 task

aladdin-add dismissed JoshuaKGoldberg’s stale review via 9ec719e April 11, 2024 09:46

aladdin-add force-pushed the chore/rm-eslintrc branch from 83d6ebe to 9ec719e Compare April 11, 2024 09:46

This was referenced Aug 22, 2024

[Snyk] Upgrade eslint from 8.57.0 to 9.8.0 nodeshift/kube-service-bindings#218

Closed

[Snyk] Upgrade eslint from 8.57.0 to 9.8.0 nodeshift/kube-service-bindings#219

Closed

jamesleesaunders mentioned this pull request Aug 28, 2024

[Snyk] Upgrade eslint from 9.6.0 to 9.8.0 jamesleesaunders/d3-ez#204

Closed

lholmquist mentioned this pull request Aug 31, 2024

[Snyk] Upgrade eslint from 8.57.0 to 9.9.0 nodeshift/kube-service-bindings#222

Closed

ekmixon mentioned this pull request Aug 31, 2024

[Snyk] Upgrade eslint from 6.8.0 to 9.9.0 ekmixon/aquasecurity-cloudsploit#141

Open

This was referenced Sep 3, 2024

[Snyk] Upgrade eslint from 8.57.0 to 9.9.0 nodeshift/kube-service-bindings#224

Closed

[Snyk] Upgrade eslint from 8.57.0 to 9.9.0 nodeshift/kube-service-bindings#225

Closed

zntb mentioned this pull request Sep 6, 2024

[Snyk] Upgrade eslint from 9.0.0 to 9.9.0 zntb/nextjs-template#28

Merged

This was referenced Sep 6, 2024

[Snyk] Upgrade eslint from 8.44.0 to 9.9.0 Sec32fun32/rust#10

Open

[Snyk] Upgrade eslint from 8.57.0 to 9.9.0 Sec32fun32/checkout#5

Open

[Snyk] Upgrade eslint from 7.31.0 to 9.9.0 Sec32fun32/teknolojirehberleri.xyz#6

Open

vinitkumar mentioned this pull request Sep 18, 2024

[Snyk] Upgrade: async, bcrypt, eslint, express-session, moment, mongoose, passport, winston vinitkumar/node-twitter#349

Merged

lholmquist mentioned this pull request Sep 19, 2024

[Snyk] Upgrade eslint from 8.57.0 to 9.9.1 nodeshift/kube-service-bindings#230

Closed

This was referenced Sep 23, 2024

[Snyk] Upgrade eslint from 6.8.0 to 9.9.1 ekmixon/aquasecurity-cloudsploit#146

Open

[Snyk] Upgrade eslint from 6.8.0 to 9.10.0 ekmixon/aquasecurity-cloudsploit#147

Open

lholmquist mentioned this pull request Sep 28, 2024

[Snyk] Upgrade eslint from 8.57.0 to 9.10.0 nodeshift/kube-service-bindings#232

Closed

This was referenced Sep 29, 2024

[Snyk] Upgrade @eslint/js from 9.3.0 to 9.10.0 tygyh/godot#3

Merged

[Snyk] Upgrade eslint from 9.3.0 to 9.10.0 tygyh/godot#4

Closed

lholmquist mentioned this pull request Oct 1, 2024

[Snyk] Upgrade eslint from 8.57.0 to 9.10.0 nodeshift/kube-service-bindings#233

Closed

tygyh mentioned this pull request Oct 2, 2024

[Snyk] Upgrade eslint from 9.3.0 to 9.10.0 tygyh/godot#6

Closed

This was referenced Oct 2, 2024

[Snyk] Upgrade eslint from 8.57.0 to 9.10.0 nodeshift/kube-service-bindings#234

Closed

[Snyk] Upgrade eslint from 8.57.0 to 9.10.0 nodeshift/kube-service-bindings#235

Closed

ebiz-markusrissmann mentioned this pull request Oct 4, 2024

[Snyk] Upgrade eslint from 8.57.1 to 9.10.0 MarkusRissmann-private/githubclient#174

Open

lholmquist mentioned this pull request Oct 5, 2024

[Snyk] Upgrade eslint from 8.57.0 to 9.10.0 nodeshift/kube-service-bindings#236

Closed

eslint-github-bot bot locked and limited conversation to collaborators Dec 16, 2024

eslint-github-bot bot added the archived due to age label Dec 16, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: remove `.eslintrc.js` #18011

chore: remove `.eslintrc.js` #18011

aladdin-add commented Jan 19, 2024 •

edited

Loading

netlify bot commented Jan 19, 2024 •

edited

Loading

nzakas commented Jan 22, 2024

aladdin-add commented Jan 23, 2024 •

edited

Loading

aladdin-add commented Jan 23, 2024

mdjermanovic commented Jan 23, 2024

nzakas commented Jan 23, 2024

aladdin-add commented Jan 24, 2024

aladdin-add commented Jan 24, 2024

mdjermanovic commented Jan 24, 2024

aladdin-add commented Jan 26, 2024

JoshuaKGoldberg left a comment

JoshuaKGoldberg Feb 2, 2024

JoshuaKGoldberg Feb 2, 2024

nzakas Feb 2, 2024

github-actions bot commented Feb 14, 2024

Rec0iL99 commented Feb 15, 2024 •

edited

Loading

	it("should throw an error if no files match a glob", () => {

	// Relying here on the .eslintignore from the repo root
	const patterns = ["tests/fixtures/glob-util/ignored/*/.js"];

	assert.throws(() => {
	listFiles(patterns);
	}, `All files matched by '${patterns[0]}' are ignored.`);
	});

chore: remove .eslintrc.js #18011

chore: remove .eslintrc.js #18011

Conversation

aladdin-add commented Jan 19, 2024 • edited Loading

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

netlify bot commented Jan 19, 2024 • edited Loading

✅ Deploy Preview for docs-eslint canceled.

nzakas commented Jan 22, 2024

aladdin-add commented Jan 23, 2024 • edited Loading

aladdin-add commented Jan 23, 2024

mdjermanovic commented Jan 23, 2024

nzakas commented Jan 23, 2024

aladdin-add commented Jan 24, 2024

aladdin-add commented Jan 24, 2024

mdjermanovic commented Jan 24, 2024

aladdin-add commented Jan 26, 2024

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

JoshuaKGoldberg Feb 2, 2024

Choose a reason for hiding this comment

JoshuaKGoldberg Feb 2, 2024

Choose a reason for hiding this comment

nzakas Feb 2, 2024

Choose a reason for hiding this comment

github-actions bot commented Feb 14, 2024

Rec0iL99 commented Feb 15, 2024 • edited Loading

chore: remove `.eslintrc.js` #18011

chore: remove `.eslintrc.js` #18011

aladdin-add commented Jan 19, 2024 •

edited

Loading

netlify bot commented Jan 19, 2024 •

edited

Loading

aladdin-add commented Jan 23, 2024 •

edited

Loading

Rec0iL99 commented Feb 15, 2024 •

edited

Loading