Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Remove CodePath#currentSegments #17756

Merged
merged 1 commit into from
Dec 20, 2023
Merged

feat!: Remove CodePath#currentSegments #17756

merged 1 commit into from
Dec 20, 2023

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented Nov 13, 2023

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[x] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Removed CodePath#currentSegments along with associated checks in RuleTester and FlatRuleTester. Also updates related documentation.

fixes #17457

Is there anything you'd like reviewers to focus on?

@eslint-github-bot eslint-github-bot bot added breaking This change is backwards-incompatible feature This change adds a new feature to ESLint labels Nov 13, 2023
Copy link

netlify bot commented Nov 13, 2023

Deploy Preview for docs-eslint ready!

Name Link
🔨 Latest commit 99cfd18
🔍 Latest deploy log https://app.netlify.com/sites/docs-eslint/deploys/658374345b01210008074e2b
😎 Deploy Preview https://deploy-preview-17756--docs-eslint.netlify.app/extend/code-path-analysis
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mdjermanovic mdjermanovic added the accepted There is consensus among the team that this change meets the criteria for inclusion label Nov 20, 2023
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@nzakas nzakas marked this pull request as ready for review December 20, 2023 23:04
@nzakas nzakas requested a review from a team as a code owner December 20, 2023 23:04
@nzakas nzakas merged commit e501ab9 into main Dec 20, 2023
7 checks passed
@nzakas nzakas deleted the issue17457 branch December 20, 2023 23:19
nzakas added a commit that referenced this pull request Dec 20, 2023
@nzakas nzakas restored the issue17457 branch December 20, 2023 23:39
nzakas added a commit that referenced this pull request Dec 20, 2023
Revert "feat!: Remove CodePath#currentSegments (#17756)"

This reverts commit e501ab9.
bmish added a commit to bmish/eslint that referenced this pull request Dec 27, 2023
* main: (25 commits)
  test: ensure that CLI tests run with FlatESLint (eslint#17884)
  fix!: Behavior of CLI when no arguments are passed (eslint#17644)
  docs: Update README
  Revert "feat!: Remove CodePath#currentSegments" (eslint#17890)
  feat!: Update shouldUseFlatConfig and CLI so flat config is default (eslint#17748)
  feat!: Remove CodePath#currentSegments (eslint#17756)
  chore: update dependency markdownlint-cli to ^0.38.0 (eslint#17865)
  feat!: deprecate no-new-symbol, recommend no-new-native-nonconstructor (eslint#17710)
  feat!: check for parsing errors in suggestion fixes (eslint#16639)
  feat!: assert suggestion messages are unique in rule testers (eslint#17532)
  feat!: `no-invalid-regexp` make allowConstructorFlags case-sensitive (eslint#17533)
  fix!: no-sequences rule schema correction (eslint#17878)
  feat!: Update `eslint:recommended` configuration (eslint#17716)
  feat!: drop support for string configurations in flat config array (eslint#17717)
  feat!: Remove `SourceCode#getComments()` (eslint#17715)
  feat!: Remove deprecated context methods (eslint#17698)
  feat!: Swap FlatESLint-ESLint, FlatRuleTester-RuleTester in API (eslint#17823)
  feat!: remove formatters except html, json(-with-metadata), and stylish (eslint#17531)
  feat!: Require Node.js `^18.18.0 || ^20.9.0 || >=21.1.0` (eslint#17725)
  fix: allow circular references in config (eslint#17752)
  ...
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Jun 18, 2024
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jun 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion breaking This change is backwards-incompatible feature This change adds a new feature to ESLint
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Change Request: Deprecate and remove CodePath#currentSegments
2 participants