Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: resubmit custom-rules doc changes #17294

Merged
merged 1 commit into from
Jun 16, 2023

Conversation

aladdin-add
Copy link
Member

@aladdin-add aladdin-add commented Jun 15, 2023

credits: https://github.com/snitin315

Refs:

it contains the docs changes in following PRs as suggested:

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Leaving open for @snitin315 to review and as the original author give permission for these changes to be merged.

Copy link
Contributor

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the original author, I give permission to merge these changes.

@snitin315 snitin315 merged commit 67e7af3 into eslint:main Jun 16, 2023
@aladdin-add aladdin-add deleted the docs/custom-rules branch June 16, 2023 05:59
gisbdzhch pushed a commit to gisktzh/gb3-web_ui that referenced this pull request Jul 4, 2023
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [eslint](https://eslint.org) ([source](https://github.com/eslint/eslint)) | devDependencies | minor | [`8.42.0` -> `8.43.0`](https://renovatebot.com/diffs/npm/eslint/8.42.0/8.43.0) |

---

### Release Notes

<details>
<summary>eslint/eslint (eslint)</summary>

### [`v8.43.0`](https://github.com/eslint/eslint/releases/tag/v8.43.0)

[Compare Source](eslint/eslint@v8.42.0...v8.43.0)

#### Features

-   [`14581ff`](eslint/eslint@14581ff) feat: directive prologue detection and autofix condition in `quotes` ([#&#8203;17284](eslint/eslint#17284)) (Francesco Trotta)
-   [`e50fac3`](eslint/eslint@e50fac3) feat: add declaration loc to message in block-scoped-var ([#&#8203;17252](eslint/eslint#17252)) (Milos Djermanovic)
-   [`1b7faf0`](eslint/eslint@1b7faf0) feat: add `skipJSXText` option to `no-irregular-whitespace` rule ([#&#8203;17182](eslint/eslint#17182)) (Azat S)

#### Bug Fixes

-   [`5338b56`](eslint/eslint@5338b56) fix: normalize `cwd` passed to `ESLint`/`FlatESLint` constructor ([#&#8203;17277](eslint/eslint#17277)) (Milos Djermanovic)
-   [`54383e6`](eslint/eslint@54383e6) fix: Remove `no-extra-parens` autofix for potential directives ([#&#8203;17022](eslint/eslint#17022)) (Francesco Trotta)

#### Documentation

-   [`8b855ea`](eslint/eslint@8b855ea) docs: resubmit pr17061 doc changes ([#&#8203;17292](eslint/eslint#17292)) (唯然)
-   [`372722e`](eslint/eslint@372722e) docs: resubmit pr17012 doc changes ([#&#8203;17293](eslint/eslint#17293)) (唯然)
-   [`67e7af3`](eslint/eslint@67e7af3) docs: resubmit custom-rules doc changes ([#&#8203;17294](eslint/eslint#17294)) (唯然)
-   [`9e3d77c`](eslint/eslint@9e3d77c) docs: Resubmit Fix formatting in Custom Rules docs ([#&#8203;17281](eslint/eslint#17281)) (Milos Djermanovic)
-   [`503647a`](eslint/eslint@503647a) docs: Resubmit markVariableAsUsed docs ([#&#8203;17280](eslint/eslint#17280)) (Nicholas C. Zakas)
-   [`e0cf0d8`](eslint/eslint@e0cf0d8) docs: Custom rule & plugin tutorial ([#&#8203;170...
@eslint-github-bot eslint-github-bot bot locked and limited conversation to collaborators Dec 14, 2023
@eslint-github-bot eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Dec 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants