-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Resubmit custom rules update docs #17273
docs: Resubmit custom rules update docs #17273
Conversation
Done b/c need to have OSS license apply to them. See eslint#17225
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note that in this file some URL slugs that weren't in the original PR (#16906) are updated here.
that must have been a change that happened to the migration guide since the custom rules page was merged. however, these new links all seem to be correct, so might as well keep in the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
undone!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approval is granted for the resubmit of custom rules update docs. Thanks
Done b/c need to have OSS license apply to them.
See #17225
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Resubmitted docs for custom rules updates, which were originally merged in #16906.
Is there anything you'd like reviewers to focus on?
Nothing in this PR has hasn't already been reviewed. Just copy-paste of files from #16906. Worth giving this a sanity check to make sure I didn't mess anything up though.
see also https://github.com/eslint/eslint/pull/17273/files#r1225856526