fix: incorrect warning message for ignored dotfiles #17196
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
Tell us about your environment (
npx eslint --env-info
):What parser are you using (place an "X" next to just one item)?
[x]
Default (Espree)
[ ]
@typescript-eslint/parser
[ ]
@babel/eslint-parser
[ ]
vue-eslint-parser
[ ]
@angular-eslint/template-parser
[ ]
Other
Please show your full configuration:
Configuration
This project's eslint.config.js
What did you do? Please include the actual source code causing the issue.
In eslint/eslint main branch, I ran this command:
What did you expect to happen?
The flat config system doesn't ignore dotfiles by default. This file is ignored by pattern
"tests/fixtures/**"
in the config file.I'd expect the common warning message for files ignored by the user's configuration:
What actually happened? Please include the actual, raw output from ESLint.
The message suggests that the file is ignored by default:
What changes did you make? (Give an overview)
In
function createIgnoreResult
, I removed the conditional for dotfiles. After the change, this case will fall into the "File ignored because of a matching ignore pattern" branch.Is there anything you'd like reviewers to focus on?