feat: add `skipJSXText` option to `no-irregular-whitespace` rule #17182

azat-io · 2023-05-14T13:01:48Z

Prerequisites checklist

I have read the contributing guidelines.

What is the purpose of this pull request? (put an "X" next to an item)

What changes did you make? (Give an overview)

Currently you can use irregular whitespace with rule options in strings: https://eslint.org/docs/latest/rules/no-irregular-whitespace#options
Sometimes I use non-breaking spaces also in JSX text. It would be nice to have this option in no-irregular-whitespace rule.

Is there anything you'd like reviewers to focus on?

Nope

What rule do you want to change?

no-irregular-whitespace

What change do you want to make (place an "X" next to just one item)?

Generate more warnings
Generate fewer warnings
Implement autofix
Implement suggestions

None of this. I added one more option to rule.

How will the change be implemented (place an "X" next to just one item)?

A new option
A new default behavior
Other

Please provide some example code that this change will affect:

Currently I cannot do that:

<div>Some text with irregular spaces</div>

What does the rule currently do for this code?

Currently, if I use non-breaking spaces in JSX text, I get the error.

What will the rule do after it's changed?

Added option to use irregular spaces in JSX text, similar to options for regular expressions and strings.

linux-foundation-easycla · 2023-05-14T13:01:53Z

The committers listed above are authorized under a signed CLA.

✅ login: azat-io / name: Azat S. (b3dddfd, 59390be, 897b358, 1424b3f, 95c6095, b1f0db4)

netlify · 2023-05-14T13:02:05Z

✅ Deploy Preview for docs-eslint canceled.

Name	Link
🔨 Latest commit	`877ad2d`
🔍 Latest deploy log	https://app.netlify.com/sites/docs-eslint/deploys/647a3e5eaec3b20008f659b3

Rec0iL99

Hi @azat-io, thanks for the suggestion. Please follow the pull request template in the description providing more info for the reviewers. Thanks.

azat-io · 2023-05-14T19:46:57Z

@Rec0iL99 Done ✅

mdjermanovic · 2023-05-15T11:47:28Z

@azat-io can you also copy & paste this template into the original post and fill it out?

azat-io · 2023-05-15T12:03:45Z

@mdjermanovic Done ✅

mdjermanovic · 2023-05-15T12:19:40Z

Thanks for the input! Given that this rule already has an option to ignore strings, I think it makes sense to add an option to ignore JSX text too, so I support this proposal 👍

Let's hear what other team members think about the proposal before reviewing the code.

azat-io · 2023-05-20T18:16:03Z

Any feedback?
Sorry for the ping, I'm looking forward to this feature.

azat-io · 2023-05-27T15:11:13Z

Ping

Rec0iL99 · 2023-05-28T01:32:57Z

@azat-io some of our team members are unavailable at the moment. Please be patient as we might experience some delays in the review process.

nzakas · 2023-06-01T18:10:23Z

I'm support this change. 👍

nzakas

LGTM. Would like another team member to verify before merging.

mdjermanovic

Code LGTM, I left suggestions about the docs and tests.

docs/src/rules/no-irregular-whitespace.md

tests/lib/rules/no-irregular-whitespace.js

lib/rules/no-irregular-whitespace.js

mdjermanovic · 2023-06-02T18:56:22Z

@azat-io can you fix lint errors (trailing commas in invalid tests)?

Otherwise, this looks good, but since it includes a documentation update, due to #17225 this will have to wait for #17231 to be merged first, and then this branch should be rebased on top of main.

azat-io · 2023-06-02T19:11:24Z

@mdjermanovic Done ✅

Strange, lint command does not work for me:

mdjermanovic · 2023-06-08T11:27:10Z

@azat-io looks like your package manager doesn't work with file: links. Either way, the lint errors are fixed now, and everything looks good, but since this includes a documentation update and there were certain licensing issues (#17225) that are now resolved on the main branch, could you please rebase this branch on top of main?

azat-io · 2023-06-08T11:32:07Z

@mdjermanovic Rebased ✅

mdjermanovic

LGTM, thanks!

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [eslint](https://eslint.org) ([source](https://github.com/eslint/eslint)) | devDependencies | minor | [`8.42.0` -> `8.43.0`](https://renovatebot.com/diffs/npm/eslint/8.42.0/8.43.0) | --- ### Release Notes <details> <summary>eslint/eslint (eslint)</summary> ### [`v8.43.0`](https://github.com/eslint/eslint/releases/tag/v8.43.0) [Compare Source](eslint/eslint@v8.42.0...v8.43.0) #### Features - [`14581ff`](eslint/eslint@14581ff) feat: directive prologue detection and autofix condition in `quotes` ([#17284](eslint/eslint#17284)) (Francesco Trotta) - [`e50fac3`](eslint/eslint@e50fac3) feat: add declaration loc to message in block-scoped-var ([#17252](eslint/eslint#17252)) (Milos Djermanovic) - [`1b7faf0`](eslint/eslint@1b7faf0) feat: add `skipJSXText` option to `no-irregular-whitespace` rule ([#17182](eslint/eslint#17182)) (Azat S) #### Bug Fixes - [`5338b56`](eslint/eslint@5338b56) fix: normalize `cwd` passed to `ESLint`/`FlatESLint` constructor ([#17277](eslint/eslint#17277)) (Milos Djermanovic) - [`54383e6`](eslint/eslint@54383e6) fix: Remove `no-extra-parens` autofix for potential directives ([#17022](eslint/eslint#17022)) (Francesco Trotta) #### Documentation - [`8b855ea`](eslint/eslint@8b855ea) docs: resubmit pr17061 doc changes ([#17292](eslint/eslint#17292)) (唯然) - [`372722e`](eslint/eslint@372722e) docs: resubmit pr17012 doc changes ([#17293](eslint/eslint#17293)) (唯然) - [`67e7af3`](eslint/eslint@67e7af3) docs: resubmit custom-rules doc changes ([#17294](eslint/eslint#17294)) (唯然) - [`9e3d77c`](eslint/eslint@9e3d77c) docs: Resubmit Fix formatting in Custom Rules docs ([#17281](eslint/eslint#17281)) (Milos Djermanovic) - [`503647a`](eslint/eslint@503647a) docs: Resubmit markVariableAsUsed docs ([#17280](eslint/eslint#17280)) (Nicholas C. Zakas) - [`e0cf0d8`](eslint/eslint@e0cf0d8) docs: Custom rule & plugin tutorial ([#170...

azat-io requested a review from a team as a code owner May 14, 2023 13:01

eslint-github-bot bot added the feature This change adds a new feature to ESLint label May 14, 2023

Rec0iL99 requested changes May 14, 2023

View reviewed changes

mdjermanovic added rule Relates to ESLint's core rules evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels May 15, 2023

nzakas added accepted There is consensus among the team that this change meets the criteria for inclusion and removed evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels Jun 1, 2023

nzakas approved these changes Jun 1, 2023

View reviewed changes

mdjermanovic added the contributor pool label Jun 2, 2023

mdjermanovic requested changes Jun 2, 2023

View reviewed changes

docs/src/rules/no-irregular-whitespace.md Show resolved Hide resolved

tests/lib/rules/no-irregular-whitespace.js Show resolved Hide resolved

mdjermanovic reviewed Jun 2, 2023

View reviewed changes

lib/rules/no-irregular-whitespace.js Outdated Show resolved Hide resolved

azat-io added 6 commits June 8, 2023 14:30

feat: add skipJSXText option to no-irregular-whitespace rule

b3dddfd

fix: remove unnecessary jsx text value check

59390be

docs: fix no-irregular-whitespace docs

897b358

test: add invalid cases for jsx in no-irregular-whitespace rule

1424b3f

docs: fix check jsx node func jsdoc

95c6095

style: fix trailing commas

b1f0db4

azat-io force-pushed the feat/skip-jsx-text branch from 877ad2d to b1f0db4 Compare June 8, 2023 11:31

mdjermanovic approved these changes Jun 8, 2023

View reviewed changes

mdjermanovic merged commit 1b7faf0 into eslint:main Jun 8, 2023

eslint-github-bot bot locked and limited conversation to collaborators Dec 6, 2023

eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Dec 6, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add `skipJSXText` option to `no-irregular-whitespace` rule #17182

feat: add `skipJSXText` option to `no-irregular-whitespace` rule #17182

azat-io commented May 14, 2023 •

edited

Loading

linux-foundation-easycla bot commented May 14, 2023 •

edited

Loading

netlify bot commented May 14, 2023 •

edited

Loading

Rec0iL99 left a comment

azat-io commented May 14, 2023

mdjermanovic commented May 15, 2023

azat-io commented May 15, 2023

mdjermanovic commented May 15, 2023

azat-io commented May 20, 2023

azat-io commented May 27, 2023

Rec0iL99 commented May 28, 2023

nzakas commented Jun 1, 2023

nzakas left a comment

mdjermanovic left a comment

mdjermanovic commented Jun 2, 2023

azat-io commented Jun 2, 2023 •

edited

Loading

mdjermanovic commented Jun 8, 2023

azat-io commented Jun 8, 2023

mdjermanovic left a comment

feat: add skipJSXText option to no-irregular-whitespace rule #17182

feat: add skipJSXText option to no-irregular-whitespace rule #17182

Conversation

azat-io commented May 14, 2023 • edited Loading

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

linux-foundation-easycla bot commented May 14, 2023 • edited Loading

netlify bot commented May 14, 2023 • edited Loading

✅ Deploy Preview for docs-eslint canceled.

Rec0iL99 left a comment

Choose a reason for hiding this comment

azat-io commented May 14, 2023

mdjermanovic commented May 15, 2023

azat-io commented May 15, 2023

mdjermanovic commented May 15, 2023

azat-io commented May 20, 2023

azat-io commented May 27, 2023

Rec0iL99 commented May 28, 2023

nzakas commented Jun 1, 2023

nzakas left a comment

Choose a reason for hiding this comment

mdjermanovic left a comment

Choose a reason for hiding this comment

mdjermanovic commented Jun 2, 2023

azat-io commented Jun 2, 2023 • edited Loading

mdjermanovic commented Jun 8, 2023

azat-io commented Jun 8, 2023

mdjermanovic left a comment

Choose a reason for hiding this comment

feat: add `skipJSXText` option to `no-irregular-whitespace` rule #17182

feat: add `skipJSXText` option to `no-irregular-whitespace` rule #17182

azat-io commented May 14, 2023 •

edited

Loading

linux-foundation-easycla bot commented May 14, 2023 •

edited

Loading

netlify bot commented May 14, 2023 •

edited

Loading

azat-io commented Jun 2, 2023 •

edited

Loading