fix: function-paren-newline crash on "new new Foo();" #15850

coderaiser · 2022-05-07T19:49:50Z

Prerequisites checklist

I have read the contributing guidelines.

What is the purpose of this pull request? (put an "X" next to an item)

[ ] Documentation update
[x] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

function-paren-newline crashes when see the code like this:

new new Boolean();

This code has no sense, but this is correct JavaScript:

It throws TypeError when trying to execute first new after second one returns instance of an object.

coderaiser@cloudcmd:~/putout/packages/plugin-remove-useless-new$ eslint new-new.js

Oops! Something went wrong! :(

ESLint: 8.15.0

TypeError: Cannot read properties of null (reading 'range')
Occurred while linting /Users/coderaiser/putout/packages/plugin-remove-useless-new/new-new.js:1
Rule: "function-paren-newline"
    at SourceCode.getTokenAfter (/Users/coderaiser/putout/node_modules/eslint/lib/source-code/token-store/index.js:315:18)
    at validateParens (/Users/coderaiser/putout/node_modules/eslint/lib/rules/function-paren-newline.js:109:52)
    at ArrowFunctionExpression,CallExpression,FunctionDeclaration,FunctionExpression,ImportExpression,NewExpression (/Users/coderaiser/putout/node_modules/eslint/lib/rules/function-paren-newline.js:277:21)
    at ruleErrorHandler (/Users/coderaiser/putout/node_modules/eslint/lib/linter/linter.js:1114:28)
    at /Users/coderaiser/putout/node_modules/eslint/lib/linter/safe-emitter.js:45:58
    at Array.forEach (<anonymous>)
    at Object.emit (/Users/coderaiser/putout/node_modules/eslint/lib/linter/safe-emitter.js:45:38)
    at NodeEventGenerator.applySelector (/Users/coderaiser/putout/node_modules/eslint/lib/linter/node-event-generator.js:297:26)
    at NodeEventGenerator.applySelectors (/Users/coderaiser/putout/node_modules/eslint/lib/linter/node-event-generator.js:326:22)
    at NodeEventGenerator.enterNode (/Users/coderaiser/putout/node_modules/eslint/lib/linter/node-event-generator.js:340:14)
coderaiser@cloudcmd:~/putout/packages/plugin-remove-useless-new$ cat new-new.js
new new Boolean();

Is there anything you'd like reviewers to focus on?

The problem occurs on AwaitExpression switch case when we fall through to CallExpression case

eslint/lib/rules/function-paren-newline.js

Lines 192 to 209 in 9b17d6f

    
           switch (node.type) { 
        
               case "NewExpression": 
        
                   if (!node.arguments.length && !( 
        
                       astUtils.isOpeningParenToken(sourceCode.getLastToken(node, { skip: 1 })) && 
        
                       astUtils.isClosingParenToken(sourceCode.getLastToken(node)) 
        
                   )) { 
        
                       // If the NewExpression does not have parens (e.g. `new Foo`), return null. 
        
                       return null; 
        
                   } 
        
                   // falls through 
        
               case "CallExpression": 
        
                   return { 
        
                       leftParen: sourceCode.getTokenAfter(node.callee, astUtils.isOpeningParenToken), 
        
                       rightParen: sourceCode.getLastToken(node) 
        
                   };

linux-foundation-easycla · 2022-05-07T19:49:53Z

The committers listed above are authorized under a signed CLA.

✅ login: coderaiser / name: coderaiser (d42e865)

netlify · 2022-05-07T19:49:56Z

✅ Deploy Preview for docs-eslint canceled.

Name	Link
🔨 Latest commit	`dc0854e`
🔍 Latest deploy log	https://app.netlify.com/sites/docs-eslint/deploys/62791b83398d050009bd0c18

aladdin-add · 2022-05-09T02:57:31Z

@coderaiser can you sign the cla?

coderaiser · 2022-05-09T05:45:41Z

@coderaiser can you sign the cla?

Sure, I did it a couple times, but for some reason I always get redirected to eslint/eslint-visitor-keys#32 after sign up.

snitin315 · 2022-05-09T05:49:51Z

@coderaiser please make sure you are committing using the same email id which you used to sign the CLA. Please check your local git settings.

coderaiser · 2022-05-09T05:54:32Z

@coderaiser please make sure you are committing using the same email id which you used to sign the CLA. Please check your local git settings.

I tried all my emails actually, and did it about 10 times 😅. Looks like something isn’t working properly, I can’t understand why I get redirected to already merged PR in other repo 🤷.

aladdin-add · 2022-05-09T06:01:59Z

I can’t understand why I get redirected to already merged PR in other repo 🤷.

I guess it's another OpenJS project, and is using the easyCLA too. 😂

coderaiser · 2022-05-09T09:02:09Z

I guess it's another OpenJS project, and is using the easyCLA too. 😂

But how this separate project related to Missing ID on Commit button I'm clicking opening the link https://api.easycla.lfx.linuxfoundation.org/v2/repository-provider/github/sign/19114526/11061773/15850/#/?version=2.

Does this easyCLA remember projects that was signed before? Maybe this link is misconfigured?

aladdin-add · 2022-05-09T09:14:13Z

https://github.com/openjs-foundation/EasyCLA#openjs-foundation-cla
Once a contributor is authorized for one OpenJS Foundation project, the signature is recognized for any other OpenJS Foundation repos that use EasyCLA.

aladdin-add · 2022-05-09T09:14:42Z

looks happy now. 👍

lib/rules/function-paren-newline.js

mdjermanovic

LGTM, thanks!

I'll leave this open until we conclude the current release (#15805).

mdjermanovic · 2022-05-09T22:32:30Z

Thanks for contributing!

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [eslint](https://eslint.org) ([source](https://github.com/eslint/eslint)) | devDependencies | minor | [`8.15.0` -> `8.16.0`](https://renovatebot.com/diffs/npm/eslint/8.15.0/8.16.0) | --- ### Release Notes <details> <summary>eslint/eslint</summary> ### [`v8.16.0`](https://github.com/eslint/eslint/releases/tag/v8.16.0) [Compare Source](eslint/eslint@v8.15.0...v8.16.0) #### Features - [`cab0c22`](eslint/eslint@cab0c22) feat: add Unicode flag suggestion in no-misleading-character-class ([#15867](eslint/eslint#15867)) (Milos Djermanovic) - [`38ae956`](eslint/eslint@38ae956) feat: check Unicode code point escapes in no-control-regex ([#15862](eslint/eslint#15862)) (Milos Djermanovic) - [`ee69cd3`](eslint/eslint@ee69cd3) feat: Update global variables ([#15871](eslint/eslint#15871)) (Sébastien Règne) #### Bug Fixes - [`3f09aab`](eslint/eslint@3f09aab) fix: function-paren-newline crash on "new new Foo();" ([#15850](eslint/eslint#15850)) (coderaiser) #### Documentation - [`050d5f4`](eslint/eslint@050d5f4) docs: Static further reading links ([#15890](eslint/eslint#15890)) (Nicholas C. Zakas) - [`36287c0`](eslint/eslint@36287c0) docs: fix absolute paths in related rules shortcode to work from /docs ([#15892](eslint/eslint#15892)) (Milos Djermanovic) - [`90b6990`](eslint/eslint@90b6990) docs: fix absolute links in rule macro to work from /docs ([#15891](eslint/eslint#15891)) (Milos Djermanovic) - [`f437249`](eslint/eslint@f437249) docs: Adjust docs site path prefix ([#15889](eslint/eslint#15889)) (Nicholas C. Zakas) - [`6e16025`](eslint/eslint@6e16025) docs: update 'Related Rules' and 'Further Reading' in remaining rules ([#15884](eslint/eslint#15884)) (Milos Djermanovic) - [`1d39f69`](eslint/eslint@1d39f69) docs: remove confusing examples for no-mixed-operators ([#15875](eslint/eslint#15875)) (Milos Djermanovic) - [`3071d76`](eslint/eslint@3071d76) docs: Fix some grammar issues ([#15837](eslint/eslint#15837)) (byodian) #### Chores - [`1768d0d`](eslint/eslint@1768d0d) chore: upgrade [@eslint/eslintrc](https://github.com/eslint/eslintrc)[@1](https://github.com/1).3.0 ([#15903](eslint/eslint#15903)) (Milos Djermanovic) - [`c686e4c`](eslint/eslint@c686e4c) chore: Add deploy workflow for docs site ([#15894](eslint/eslint#15894)) (Nicholas C. Zakas) - [`c7894cd`](eslint/eslint@c7894cd) chore: enable some rules from eslint-plugin-unicorn internally ([#15878](eslint/eslint#15878)) (Bryan Mishkin) - [`ea65cb5`](eslint/eslint@ea65cb5) chore: upgrade eslint-plugin-eslint-plugin@^4.2.0 ([#15882](eslint/eslint#15882)) (唯然) - [`cc29c69`](eslint/eslint@cc29c69) chore: Upgrade official GitHub actions to latest versions ([#15880](eslint/eslint#15880)) (Darius Dzien) - [`5891c75`](eslint/eslint@5891c75) chore: Refactor rule docs format ([#15869](eslint/eslint#15869)) (Nicholas C. Zakas) </details> --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1366 Reviewed-by: 6543 <6543@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>

* fix: function-paren-newline: crash on "new new Foo();" * fix: function-paren-newline: false negative case support

…#15850)" This reverts commit b8b86c2.

eslint-github-bot bot added triage An ESLint team member will look at this issue soon bug ESLint is working incorrectly labels May 7, 2022

fix: function-paren-newline: crash on "new new Foo();"

d42e865

coderaiser force-pushed the fix/function-paren-newline branch from 786c058 to d42e865 Compare May 9, 2022 09:11

mdjermanovic added rule Relates to ESLint's core rules accepted There is consensus among the team that this change meets the criteria for inclusion and removed triage An ESLint team member will look at this issue soon labels May 9, 2022

mdjermanovic requested changes May 9, 2022

View reviewed changes

lib/rules/function-paren-newline.js Outdated Show resolved Hide resolved

fix: function-paren-newline: false negative case support

dc0854e

coderaiser requested a review from mdjermanovic May 9, 2022 13:47

mdjermanovic changed the title ~~fix: function-paren-newline: crash on "new new Foo();"~~ fix: function-paren-newline crash on "new new Foo();" May 9, 2022

mdjermanovic approved these changes May 9, 2022

View reviewed changes

mdjermanovic merged commit 3f09aab into eslint:main May 9, 2022

srijan-deepsource added a commit to DeepSourceCorp/eslint that referenced this pull request May 30, 2022

Revert "fix: function-paren-newline crash on "new new Foo();" (eslint…

6f00557

…#15850)" This reverts commit b8b86c2.

sync-by-unito bot mentioned this pull request Jun 1, 2022

build(deps-dev): bump eslint from 7.32.0 to 8.16.0 numbersprotocol/capture-lite#1657

Closed

eslint-github-bot bot locked and limited conversation to collaborators Nov 6, 2022

eslint-github-bot bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Nov 6, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: function-paren-newline crash on "new new Foo();" #15850

fix: function-paren-newline crash on "new new Foo();" #15850

coderaiser commented May 7, 2022 •

edited

Loading

linux-foundation-easycla bot commented May 7, 2022 •

edited

Loading

netlify bot commented May 7, 2022 •

edited

Loading

aladdin-add commented May 9, 2022

coderaiser commented May 9, 2022

snitin315 commented May 9, 2022

coderaiser commented May 9, 2022

aladdin-add commented May 9, 2022 •

edited

Loading

coderaiser commented May 9, 2022

aladdin-add commented May 9, 2022

aladdin-add commented May 9, 2022

mdjermanovic left a comment

mdjermanovic commented May 9, 2022

	switch (node.type) {
	case "NewExpression":
	if (!node.arguments.length && !(
	astUtils.isOpeningParenToken(sourceCode.getLastToken(node, { skip: 1 })) &&
	astUtils.isClosingParenToken(sourceCode.getLastToken(node))
	)) {

	// If the NewExpression does not have parens (e.g. `new Foo`), return null.
	return null;
	}

	// falls through

	case "CallExpression":
	return {
	leftParen: sourceCode.getTokenAfter(node.callee, astUtils.isOpeningParenToken),
	rightParen: sourceCode.getLastToken(node)
	};

fix: function-paren-newline crash on "new new Foo();" #15850

fix: function-paren-newline crash on "new new Foo();" #15850

Conversation

coderaiser commented May 7, 2022 • edited Loading

Prerequisites checklist

What is the purpose of this pull request? (put an "X" next to an item)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

linux-foundation-easycla bot commented May 7, 2022 • edited Loading

netlify bot commented May 7, 2022 • edited Loading

✅ Deploy Preview for docs-eslint canceled.

aladdin-add commented May 9, 2022

coderaiser commented May 9, 2022

snitin315 commented May 9, 2022

coderaiser commented May 9, 2022

aladdin-add commented May 9, 2022 • edited Loading

coderaiser commented May 9, 2022

aladdin-add commented May 9, 2022

aladdin-add commented May 9, 2022

mdjermanovic left a comment

Choose a reason for hiding this comment

mdjermanovic commented May 9, 2022

coderaiser commented May 7, 2022 •

edited

Loading

linux-foundation-easycla bot commented May 7, 2022 •

edited

Loading

netlify bot commented May 7, 2022 •

edited

Loading

aladdin-add commented May 9, 2022 •

edited

Loading