-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: migrate master to main #15062
Conversation
|
Hi @niteshseram!, thanks for the Pull Request The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.
Read more about contributing to ESLint here |
Hi @niteshseram!, thanks for the Pull Request The first commit message isn't properly formatted. We ask that you update the message to match this format, as we use it to generate changelogs and automate releases.
Read more about contributing to ESLint here |
6a37dfc
to
fe992b6
Compare
Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
.github/PULL_REQUEST_TEMPLATE.md
Outdated
@@ -6,7 +6,7 @@ | |||
|
|||
#### Prerequisites checklist | |||
|
|||
- [ ] I have read the [contributing guidelines](https://github.com/eslint/eslint/blob/master/CONTRIBUTING.md). | |||
- [ ] I have read the [contributing guidelines](https://github.com/eslint/eslint/blob/main/CONTRIBUTING.md). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- [ ] I have read the [contributing guidelines](https://github.com/eslint/eslint/blob/main/CONTRIBUTING.md). | |
- [ ] I have read the [contributing guidelines](https://github.com/eslint/eslint/blob/HEAD/CONTRIBUTING.md). |
this way it will always work, now and later, and won't need to be coordinated with the default branch change.
Same for every URL in the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review @ljharb. I made the changes in all the URLs.
Co-authored-by: Jordan Harband <ljharb@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks for doing this. We will have to coordinate renaming the master branch with merging this PR.
@nzakas the way it’s written, you don’t - you can merge this, and only the instructions will be wrong until you change the branch. |
@ljharb good point! I'll just wait for @mdjermanovic to ensure his concerns were addressed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
It seems that GitHub does not redirect This is a link to update one document in eslint/espree (which was switched from master to main): https://github.com/eslint/espree/edit/main/docs/tokens.md But it doesn't redirect the same link with master: https://github.com/eslint/espree/edit/master/docs/tokens.md So, we'll have to update all edit links manually in eslint/website when we switch eslint/eslint to main. Otherwise, they will be broken until the final ESLint v8.0.0 release overwrites them. |
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[X] Other, please explain:
Migrate branch from master to main
What changes did you make? (Give an overview)
I have updated the occurrence of word master to main in GitHub action, Makefile.js and some docs
Closes #15042