New: Add no-unused-private-class-members rule (fixes #14859) #14895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For any private class property or method, report those that are unused. Since private class members can only be accessed in the same class body, we can safely assume that all usages are processed when we leave the ClassBody scope.
eslint-github-bot
bot
added
the
triage
mdjermanovic
added
evaluating
btmills
added
accepted
nzakas
requested changes
Sep 16, 2021
|
Note to team: this is covered by the old CLA |
mdjermanovic
requested changes
Sep 19, 2021
mdjermanovic
requested changes
Sep 19, 2021
|
Thanks @mdjermanovic for your detailed review! I should have some time this week to fix these issues. |
Also remove the rule from recommended for now, as that is a breaking change.
|
|
It's Friday and that means edge case galore! I think I handled all cases now, with loads of new tests 😄 |
This also removes the usage of optional chaining, which isn't supported yet on Node environments that ESLint supports.
nzakas
requested changes
Oct 2, 2021
|
@nzakas Done 👍 |
mdjermanovic
requested changes
Oct 4, 2021
|
@mdjermanovic Thanks for all the edge cases! I battle-hardened the nested classes scenarios and also added another regression test with regards to double usage of an inner class property, where it would incorrectly mark the parent class property as used. |
mdjermanovic
requested changes
Oct 14, 2021
Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
Co-authored-by: Milos Djermanovic <milos.djermanovic@gmail.com>
|
I am on GitHub right now, so I hope that my GitHub edit was working. The last change I can make tomorrow (I think) on my laptop. |
|
Ah nvm. I will just clean it up tomorrow so that I can fix the linter as well. |
mdjermanovic
changed the title
mdjermanovic
approved these changes
Oct 22, 2021
eslint-github-bot
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For any private class property or method, report those that are
unused. Since private class members can only be accessed in the
same class body, we can safely assume that all usages are processed
when we leave the ClassBody scope.
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[ ] Documentation update
[ ] Bug fix (template)
[X] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
What changes did you make? (Give an overview)
Implement the rule for reporting unused private class members (#14859)
Is there anything you'd like reviewers to focus on?
I have tried to figure out all potential edge cases for usages of these variables. There might be edge cases that I missed, so it would be great to add more if you can think of any.