Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Optionally allow underscores in member names #11972

Merged
merged 2 commits into from
Feb 28, 2020
Merged

Fix: Optionally allow underscores in member names #11972

merged 2 commits into from
Feb 28, 2020

Conversation

eaviles
Copy link
Contributor

@eaviles eaviles commented Jul 9, 2019

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[X] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)
I included the check to see if the identifier is allowed when validating member names in the no-underscore-dangle rule.

Is there anything you'd like reviewers to focus on?
Not sure if ignoring the "allow" option with member names was the original behavior.

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Jul 9, 2019
@aladdin-add aladdin-add added bug ESLint is working incorrectly evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion rule Relates to ESLint's core rules and removed triage An ESLint team member will look at this issue soon labels Jul 11, 2019
@platinumazure
Copy link
Member

Hi @eaviles, thanks for the PR!

Hmm... This does seem like a bug to me, but I'd like to get opinions from more team members.

@kaicataldo kaicataldo added accepted There is consensus among the team that this change meets the criteria for inclusion and removed evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels Dec 14, 2019
@kaicataldo
Copy link
Member

So sorry for the delay here. I agree that this looks like a bug. Marking as accepted. @eaviles Are you able and still willing to fix the merge conflict?

@eaviles
Copy link
Contributor Author

eaviles commented Dec 14, 2019

So sorry for the delay here. I agree that this looks like a bug. Marking as accepted. @eaviles Are you able and still willing to fix the merge conflict?

Hi @kaicataldo thanks for the review. Yeah I’m still able and willing, I’ll take care of the merge conflict ASAP!

@kaicataldo
Copy link
Member

Friendly ping :)

@eaviles
Copy link
Contributor Author

eaviles commented Jan 17, 2020

Friendly ping :)

Ashamed pong 🙈

Taking care of this ASAP!

@kaicataldo
Copy link
Member

No worries! We appreciate you taking the time to contribute. Let us know if there's anything we can do to help!

@nzakas
Copy link
Member

nzakas commented Feb 7, 2020

@eaviles Just following up to see if you're still planning on updating this?

@nzakas
Copy link
Member

nzakas commented Feb 25, 2020

@eaviles one last check to see if you’re still working on this?

@eaviles
Copy link
Contributor Author

eaviles commented Feb 26, 2020

@kaicataldo, @nzakas: I just resolved the conflict. Waiting for the checks to complete. Ready to follow up if needed ;)

mdjermanovic
mdjermanovic approved these changes Feb 26, 2020
View reviewed changes
Copy link
Member

@mdjermanovic mdjermanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Non-blocker, it might be nice to add a test with a class method.

nzakas
nzakas approved these changes Feb 27, 2020
View reviewed changes
Copy link
Member

@nzakas nzakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@eaviles eaviles closed this Feb 27, 2020
@eaviles eaviles reopened this Feb 27, 2020
@eaviles
Copy link
Contributor Author

eaviles commented Feb 27, 2020

@kaicataldo, @nzakas, @mdjermanovic, @kaicataldo: trying to follow up… what's next? I can't merge this myself so just wondering about the procedure.

@nzakas
Copy link
Member

nzakas commented Feb 28, 2020

@mdjermanovic are you ok with merging without further changes (unclear from your comment).

@mdjermanovic
Copy link
Member

@mdjermanovic are you ok with merging without further changes (unclear from your comment).

Yes, I'm ok with merging this without further changes.

kaicataldo
kaicataldo approved these changes Feb 28, 2020
View reviewed changes
Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Sorry again for the initial delay in reviewing this, and we appreciate you sticking with it :)

@kaicataldo kaicataldo merged commit 5775b06 into eslint:master Feb 28, 2020
@kaicataldo
Copy link
Member

Thanks for contributing to ESLint.

montmanu pushed a commit to montmanu/eslint that referenced this pull request Mar 4, 2020
@eaviles @montmanu
Fix: Optionally allow underscores in member names (eslint#11972)
d866f9b
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Aug 28, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Aug 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mdjermanovic mdjermanovic mdjermanovic approved these changes

@kaicataldo kaicataldo kaicataldo approved these changes

@nzakas nzakas nzakas approved these changes

Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly rule Relates to ESLint's core rules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@eaviles @platinumazure @kaicataldo @nzakas @mdjermanovic @aladdin-add