Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: eslint/eslint
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v7.12.0
Choose a base ref
...
head repository: eslint/eslint
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v7.12.1
Choose a head ref
  • 5 commits
  • 6 files changed
  • 2 contributors

Commits on Oct 24, 2020

  1. Sponsors: Sync README with website

    ESLint Jenkins committed Oct 24, 2020
    3 Configuration menu
    Copy the full SHA
    631ae8b View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2020

  1. Fix: Pass internal config paths in FileEnumerator default (fixes #13789

    …) (#13792)
    
    * Chore: Repro FileEnumerator exception with default args (refs #13789)
    
    When `CLIEngine` instantiates `FileEnumerator`, it explicitly passes its
    own `CascadingConfigArrayFactory` instance, which now includes values
    for `builtInRules`, `loadRules`, `eslintRecommendedPath`, and
    `eslintAllPath`. This is the only place that ESLint core instantiates
    `FileEnumerator`, so core does not rely on the constructor's default
    value for `configArrayFactory`.
    
    After `CascadingConfigArrayFactory` was extracted into
    `@eslint/eslintrc`, it no longer assumed values for
    `eslintRecommendedPath` and `eslintAllPath`, which `CLIEngine` now
    provides. If those values are not passed, as is the case with the
    default `CascadingConfigArrayFactory` for `configArrayFactory`, file
    enumeration will encounter the exception that was reported in #13789.
    
    From the perspective of ESLint core, the default value for
    `configArrayFactory` is dead code. However, even though `FileEnumerator`
    is an undocumented API, it's called by `eslint-plugin-import`'s
    `no-unused-modules` rule, which hits the exception reproduced by this
    test.
    
    * Fix: Pass internal config paths in FileEnumerator default (fixes #13789)
    
    When `CLIEngine` instantiates `FileEnumerator`, it explicitly passes its
    own `CascadingConfigArrayFactory` instance, which now includes values
    for `builtInRules`, `loadRules`, `eslintRecommendedPath`, and
    `eslintAllPath`. This is the only place that ESLint core instantiates
    `FileEnumerator`, so core does not rely on the constructor's default
    value for `configArrayFactory`.
    
    After `CascadingConfigArrayFactory` was extracted into
    `@eslint/eslintrc`, it no longer assumed values for
    `eslintRecommendedPath` and `eslintAllPath`, which `CLIEngine` now
    provides. If those values are not passed, as is the case with the
    default `CascadingConfigArrayFactory` for `configArrayFactory`, file
    enumeration will encounter the exception that was reported in #13789.
    
    From the perspective of ESLint core, the default value for
    `configArrayFactory` is dead code. However, even though `FileEnumerator`
    is an undocumented API, it's called by `eslint-plugin-import`'s
    `no-unused-modules` rule, which hits the exception reproduced by this
    test.
    btmills authored Oct 27, 2020
    Configuration menu
    Copy the full SHA
    aeef485 View commit details
    Browse the repository at this point in the history
  2. Upgrade: @eslint/eslintrc to fix rule schema validation (fixes #13793) (

    #13794)
    
    * Chore: Repro missing built-in rule validation (refs #13793)
    
    The bulk of our tests for rule schemas are isolated unit tests of
    `ConfigValidator`. This is a single test to be sure we actually run rule
    schema validation end-to-end and prevent cases like #13793.
    
    After I run a patch release of `@eslint/eslintrc`, I'll push a second
    commit on this branch to bump the dependency version and fix the test.
    
    * Upgrade: @eslint/eslintrc for rule validation (fixes #13793)
    btmills authored Oct 27, 2020
    Configuration menu
    Copy the full SHA
    08f33e8 View commit details
    Browse the repository at this point in the history
  3. Build: changelog update for 7.12.1

    ESLint Jenkins committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    ea2d249 View commit details
    Browse the repository at this point in the history
  4. 7.12.1

    ESLint Jenkins committed Oct 27, 2020
    Configuration menu
    Copy the full SHA
    a1a9d14 View commit details
    Browse the repository at this point in the history
Loading