-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: eslint/eslint
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v7.12.0
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: eslint/eslint
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v7.12.1
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 5 commits
- 6 files changed
- 2 contributors
Commits on Oct 24, 2020
-
Sponsors: Sync README with website
ESLint Jenkins committedOct 24, 2020 3Configuration menu - View commit details
-
Copy full SHA for 631ae8b - Browse repository at this point
Copy the full SHA 631ae8bView commit details
Commits on Oct 27, 2020
-
Fix: Pass internal config paths in FileEnumerator default (fixes #13789…
…) (#13792) * Chore: Repro FileEnumerator exception with default args (refs #13789) When `CLIEngine` instantiates `FileEnumerator`, it explicitly passes its own `CascadingConfigArrayFactory` instance, which now includes values for `builtInRules`, `loadRules`, `eslintRecommendedPath`, and `eslintAllPath`. This is the only place that ESLint core instantiates `FileEnumerator`, so core does not rely on the constructor's default value for `configArrayFactory`. After `CascadingConfigArrayFactory` was extracted into `@eslint/eslintrc`, it no longer assumed values for `eslintRecommendedPath` and `eslintAllPath`, which `CLIEngine` now provides. If those values are not passed, as is the case with the default `CascadingConfigArrayFactory` for `configArrayFactory`, file enumeration will encounter the exception that was reported in #13789. From the perspective of ESLint core, the default value for `configArrayFactory` is dead code. However, even though `FileEnumerator` is an undocumented API, it's called by `eslint-plugin-import`'s `no-unused-modules` rule, which hits the exception reproduced by this test. * Fix: Pass internal config paths in FileEnumerator default (fixes #13789) When `CLIEngine` instantiates `FileEnumerator`, it explicitly passes its own `CascadingConfigArrayFactory` instance, which now includes values for `builtInRules`, `loadRules`, `eslintRecommendedPath`, and `eslintAllPath`. This is the only place that ESLint core instantiates `FileEnumerator`, so core does not rely on the constructor's default value for `configArrayFactory`. After `CascadingConfigArrayFactory` was extracted into `@eslint/eslintrc`, it no longer assumed values for `eslintRecommendedPath` and `eslintAllPath`, which `CLIEngine` now provides. If those values are not passed, as is the case with the default `CascadingConfigArrayFactory` for `configArrayFactory`, file enumeration will encounter the exception that was reported in #13789. From the perspective of ESLint core, the default value for `configArrayFactory` is dead code. However, even though `FileEnumerator` is an undocumented API, it's called by `eslint-plugin-import`'s `no-unused-modules` rule, which hits the exception reproduced by this test.
Configuration menu - View commit details
-
Copy full SHA for aeef485 - Browse repository at this point
Copy the full SHA aeef485View commit details -
Upgrade: @eslint/eslintrc to fix rule schema validation (fixes #13793) (
#13794) * Chore: Repro missing built-in rule validation (refs #13793) The bulk of our tests for rule schemas are isolated unit tests of `ConfigValidator`. This is a single test to be sure we actually run rule schema validation end-to-end and prevent cases like #13793. After I run a patch release of `@eslint/eslintrc`, I'll push a second commit on this branch to bump the dependency version and fix the test. * Upgrade: @eslint/eslintrc for rule validation (fixes #13793)
Configuration menu - View commit details
-
Copy full SHA for 08f33e8 - Browse repository at this point
Copy the full SHA 08f33e8View commit details -
Build: changelog update for 7.12.1
ESLint Jenkins committedOct 27, 2020 Configuration menu - View commit details
-
Copy full SHA for ea2d249 - Browse repository at this point
Copy the full SHA ea2d249View commit details -
ESLint Jenkins committed
Oct 27, 2020 Configuration menu - View commit details
-
Copy full SHA for a1a9d14 - Browse repository at this point
Copy the full SHA a1a9d14View commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v7.12.0...v7.12.1