feat!: Update eslint:recommended configuration (#17716)

Adds new rules no-constant-binary-expression, no-empty-static-block and no-unused-private-class-members. Removes deprecated rules no-extra-semi and no-mixed-spaces-and-tabs. Fixes #17596
eslint · Dec 20, 2023 · 6ee3e9e · 6ee3e9e
1 parent c2cf85a
commit 6ee3e9e
Show file tree

Hide file tree

Showing 8 changed files with 10 additions and 7 deletions.
diff --git a/lib/rules/no-constant-binary-expression.js b/lib/rules/no-constant-binary-expression.js
@@ -440,7 +440,7 @@ module.exports = {
         type: "problem",
         docs: {
             description: "Disallow expressions where the operation doesn't affect the value",
-            recommended: false,
+            recommended: true,
             url: "https://eslint.org/docs/latest/rules/no-constant-binary-expression"
         },
         schema: [],

diff --git a/lib/rules/no-empty-static-block.js b/lib/rules/no-empty-static-block.js
@@ -15,7 +15,7 @@ module.exports = {
 
         docs: {
             description: "Disallow empty static blocks",
-            recommended: false,
+            recommended: true,
             url: "https://eslint.org/docs/latest/rules/no-empty-static-block"
         },
 

diff --git a/lib/rules/no-extra-semi.js b/lib/rules/no-extra-semi.js
@@ -26,7 +26,7 @@ module.exports = {
 
         docs: {
             description: "Disallow unnecessary semicolons",
-            recommended: true,
+            recommended: false,
             url: "https://eslint.org/docs/latest/rules/no-extra-semi"
         },
 

diff --git a/lib/rules/no-mixed-spaces-and-tabs.js b/lib/rules/no-mixed-spaces-and-tabs.js
@@ -18,7 +18,7 @@ module.exports = {
 
         docs: {
             description: "Disallow mixed spaces and tabs for indentation",
-            recommended: true,
+            recommended: false,
             url: "https://eslint.org/docs/latest/rules/no-mixed-spaces-and-tabs"
         },
 

diff --git a/lib/rules/no-unused-private-class-members.js b/lib/rules/no-unused-private-class-members.js
@@ -16,7 +16,7 @@ module.exports = {
 
         docs: {
             description: "Disallow unused private class members",
-            recommended: false,
+            recommended: true,
             url: "https://eslint.org/docs/latest/rules/no-unused-private-class-members"
         },
 

diff --git a/packages/eslint-config-eslint/base.js b/packages/eslint-config-eslint/base.js
@@ -81,6 +81,7 @@ const jsConfigs = [js.configs.recommended, {
         "no-eval": "error",
         "no-extend-native": "error",
         "no-extra-bind": "error",
+        "no-extra-semi": "error",
         "no-floating-decimal": "error",
         "no-implied-eval": "error",
         "no-invalid-this": "error",

diff --git a/packages/eslint-config-eslint/eslintrc.js b/packages/eslint-config-eslint/eslintrc.js
@@ -223,6 +223,7 @@ module.exports = {
         "no-eval": "error",
         "no-extend-native": "error",
         "no-extra-bind": "error",
+        "no-extra-semi": "error",
         "no-floating-decimal": "error",
         "no-implied-eval": "error",
         "no-invalid-this": "error",

diff --git a/packages/js/src/configs/eslint-recommended.js b/packages/js/src/configs/eslint-recommended.js
@@ -20,6 +20,7 @@ module.exports = Object.freeze({
         "no-compare-neg-zero": "error",
         "no-cond-assign": "error",
         "no-const-assign": "error",
+        "no-constant-binary-expression": "error",
         "no-constant-condition": "error",
         "no-control-regex": "error",
         "no-debugger": "error",
@@ -32,9 +33,9 @@ module.exports = Object.freeze({
         "no-empty": "error",
         "no-empty-character-class": "error",
         "no-empty-pattern": "error",
+        "no-empty-static-block": "error",
         "no-ex-assign": "error",
         "no-extra-boolean-cast": "error",
-        "no-extra-semi": "error",
         "no-fallthrough": "error",
         "no-func-assign": "error",
         "no-global-assign": "error",
@@ -44,7 +45,6 @@ module.exports = Object.freeze({
         "no-irregular-whitespace": "error",
         "no-loss-of-precision": "error",
         "no-misleading-character-class": "error",
-        "no-mixed-spaces-and-tabs": "error",
         "no-new-symbol": "error",
         "no-nonoctal-decimal-escape": "error",
         "no-obj-calls": "error",
@@ -64,6 +64,7 @@ module.exports = Object.freeze({
         "no-unsafe-negation": "error",
         "no-unsafe-optional-chaining": "error",
         "no-unused-labels": "error",
+        "no-unused-private-class-members": "error",
         "no-unused-vars": "error",
         "no-useless-backreference": "error",
         "no-useless-catch": "error",