[Concurrency] Guard and Interleavings fix #2185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anthonysdu
commented
Dec 8, 2024
| @@ -1,4 +1,4 @@ | |||
| CORE | |||
| KNOWNBUG | |||
There was a problem hiding this comment.
This is a bug from partial order reduction,
will fix this in mpor pr.
Anthonysdu
commented
Dec 8, 2024
| if ( | ||
| last_active_thread != active_thread && | ||
| is_cur_state_guard_false(threads_state[active_thread].guard.as_expr())) | ||
| interleaving_unviable = true; |
There was a problem hiding this comment.
It is too early to set interleaving_unviable because the active_thread guard will be updated later in merge_gotos(), Instead set the value after merge_gotos()
lucasccordeiro
approved these changes
Dec 8, 2024
|
Thanks for submitting this PR, @Anthonysdu. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR https://github.com/esbmc/esbmc/actions/runs/12218538927
The result score is the same as master:
--context-bound 3 --no-porBut verification time is improved slightly:
Master:
Correct true: 6650s
Correct false: 4890s
This PR:
Correct true: 6610s
Correct false: 4340s