-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[symex] make alloca handling more robust #2095
Conversation
1e12e2f
to
157bbfa
Compare
157bbfa
to
54930be
Compare
Maybe we could replace it with a regex? Something like "alloca$\d+". |
@intrigus: could you please try this approach? |
I will not try this approach as it's also not complete, i.e. a function called The main motivation for this PR is to unblock my c++ code that uses std::allocator. |
That would generate "alloca$111$", no? |
Thanks, @intrigus. I have asked Rafael to submit another PR with his proposal. |
Don't free pointers returned from `alloca`te functions. Pointers from functions called `alloca$` will still be incorrectly freed, but this is for a future PR.
54930be
to
71f882a
Compare
Thanks for submitting this PR, @intrigus-lgtm. |
Sorry, for not being more helpful, just pretty busy and keeping my thesis' deadline in mind. |
Don't free pointers returned from
alloca
te functions. Pointers from functions calledalloca$
will still be incorrectly freed, but this is for a future PR.