Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VSA is now only computed with GCSE flag #1607

Merged
merged 3 commits into from
Jan 21, 2024
Merged

VSA is now only computed with GCSE flag #1607

merged 3 commits into from
Jan 21, 2024

Conversation

rafaelsamenezes
Copy link
Contributor

@rafaelsamenezes rafaelsamenezes commented Jan 20, 2024 •
edited
Loading

This enables VSA only when gcse is enabled. Mainly to prevent issues since VSA is not very stable

@rafaelsamenezes rafaelsamenezes mentioned this pull request Jan 20, 2024
Merged
@rafaelsamenezes rafaelsamenezes marked this pull request as draft January 20, 2024 21:50
@rafaelsamenezes rafaelsamenezes marked this pull request as ready for review January 21, 2024 14:02
fbrausse
fbrausse approved these changes Jan 21, 2024
View reviewed changes
Copy link
Collaborator

@fbrausse fbrausse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

lucasccordeiro
lucasccordeiro approved these changes Jan 21, 2024
View reviewed changes
Copy link
Contributor

@lucasccordeiro lucasccordeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this PR, @rafaelsamenezes.

@lucasccordeiro lucasccordeiro merged commit 5ed69e3 into master Jan 21, 2024
10 checks passed
@lucasccordeiro lucasccordeiro deleted the local-vsa branch January 21, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasccordeiro lucasccordeiro lucasccordeiro approved these changes

@fbrausse fbrausse fbrausse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rafaelsamenezes @fbrausse @lucasccordeiro