Fix overflow- encoding #1560
Merged
Fix overflow- encoding #1560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The overflow checks for a - b is now (a - b) <= a Signed-off-by: Mikhail R. Gadelha <mikhail@igalia.com>
|
Also, |
lucasccordeiro
approved these changes
Dec 24, 2023
There was a problem hiding this comment.
Thanks for submitting this PR, @mikhailramalho.
Shall we run it over the SV-COMP benchmarks?
|
I don't think it's necessary, there were no wrong results on the overflow
category when I last run the rework-built-in.
I've found this issue by accident when writing one of the regressions
…On Sun, 24 Dec 2023, 15:59 Lucas Cordeiro, ***@***.***> wrote:
***@***.**** approved this pull request.
Thanks for submitting this PR, @mikhailramalho
<https://github.com/mikhailramalho>.
Shall we run it over the SV-COMP benchmarks?
—
Reply to this email directly, view it on GitHub
<#1560 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKEJH4CGBI3QQFLSQHUTW3YLB3QHAVCNFSM6AAAAABBBVJC2KVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOOJVGYYTKNJQG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Thanks, @mikhailramalho. |
|
@mikhailramalho: Can I ask you whether you have run this PR over the SV-COMP benchmarks? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The overflow checks for a - b is now (a - b) <= a
Fixed #1559