Fixed crash caused by invalid id in value set #1514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbrausse
reviewed
Nov 24, 2023
src/pointer-analysis/value_set.cpp
Outdated
| @@ -1288,7 +1288,7 @@ void value_sett::assign_rec( | |||
| else if( | |||
| is_constant_string2t(lhs) || is_null_object2t(lhs) || | |||
| is_valid_object2t(lhs) || is_deallocated_obj2t(lhs) || | |||
| is_dynamic_size2t(lhs) || is_constant_array2t(lhs)) | |||
| is_dynamic_size2t(lhs) || is_constant_array2t(lhs) || is_invalid2t(lhs)) | |||
There was a problem hiding this comment.
This check should be done where the invalid2t expression is obtained originally in the recursion: in the is_dereference2t(lhs) branch. The reason is that when possible we should handle the "special" value-set expressions unknown2t, invalid2t, etc. together, such that it's clear that assign_rec() itself only handles the non-special ones; i.e., the special should not escape.
lucasccordeiro
approved these changes
Nov 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESBMC should not crash for program.
For some code that directly manipulated memory, this would cause our static analysis module to crash.