[python-frontend] Add support for non-determinism #1439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasccordeiro
requested changes
Nov 1, 2023
There was a problem hiding this comment.
Can you please add some regression tests with __VERIFIER_nondet_X()? See the definition here: https://sv-comp.sosy-lab.org/2023/rules.php
In particular, try to add some regression tests that fail too.
brcfarias
force-pushed
the
python-frontend
branch
from
ebf90a8 to
1cab16e
Compare
fbrausse
reviewed
Nov 1, 2023
|
I agree with @fbrausse. Please check these definitions: https://github.com/esbmc/esbmc/blob/master/src/clang-c-frontend/clang_c_language.cpp#L431 https://github.com/esbmc/esbmc/blob/master/src/clang-c-frontend/clang_c_language.cpp#L445 We should match them. |
lucasccordeiro
approved these changes
Nov 1, 2023
There was a problem hiding this comment.
Excellent!
Many thanks for addressing our comments, @brcfarias.
fbrausse
reviewed
Nov 1, 2023
fbrausse
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR: