Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for parsing and dumping COFF object files #164

Merged
merged 2 commits into from
May 19, 2019
Merged

Add support for parsing and dumping COFF object files #164

merged 2 commits into from
May 19, 2019

Conversation

zlatkok
Copy link
Contributor

@zlatkok zlatkok commented Jan 22, 2017

Add support for parsing and dumping COFF object files.
Dump symbol table and section relocations.
Fix some small issues.

@bernhl
Copy link
Contributor

bernhl commented Aug 4, 2017

@erocarrera are you generally fine with adding COFF parsing to pefile?
Since the PR has conflicts with master somebody would need to work on that anyway so I propose to move as much of the COFF code and constants as possible out from pefile.py into a separate coff.py.
In particular, I'd like to keep the original __parse__ function and override it in the COFF class (which inherits from PE).

@learn-more
Copy link
Contributor

@erocarrera Any update on this?

@erocarrera erocarrera merged commit bbf2892 into erocarrera:master May 19, 2019
@zlatkok zlatkok deleted the parse-coff-object-files branch May 20, 2019 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zlatkok @bernhl @learn-more @erocarrera