Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing include statements in in6addr tests #2687

Merged
merged 1 commit into from
Jul 27, 2020
Merged

Add missing include statements in in6addr tests #2687

merged 1 commit into from
Jul 27, 2020

Conversation

AquaGeek
Copy link
Contributor

@AquaGeek AquaGeek commented Jul 9, 2020

Compilation is failing on macOS Big Sur due to in6addr_any and in6addr_loopback being redeclared. The underlying issue is that the tests for these are failing due to missing include statements:

conftest.c:197:1: error: implicitly declaring library function 'printf' with type 'int (const char *, ...)' [-Werror,-Wimplicit-function-declaration]
printf("%d", in6addr_any.s6_addr[16]);
^
conftest.c:197:1: note: include the header <stdio.h> or explicitly provide a declaration for 'printf'

ERL-1306

@CLAassistant
Copy link

CLAassistant commented Jul 9, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@garazdawi garazdawi added the testing currently being tested, tag is used by OTP internal CI label Jul 10, 2020
@garazdawi garazdawi changed the base branch from master to maint July 10, 2020 06:44
@garazdawi garazdawi added fix team:VM Assigned to OTP team VM labels Jul 10, 2020
@garazdawi garazdawi changed the base branch from maint to master July 10, 2020 06:44
@garazdawi
Copy link
Contributor

Thanks! Would you mind rebasing this for inclusion in the maint branch?

@garazdawi garazdawi removed the testing currently being tested, tag is used by OTP internal CI label Jul 10, 2020
@AquaGeek
Add missing include statements in in6addr tests
388622e 
Compilation is failing on macOS Big Sur due to in6addr_any and in6addr_loopback
being redeclared. The underlying issue is that the tests for these are failing
due to missing include statements:

conftest.c:197:1: error: implicitly declaring library function 'printf'
with type 'int (const char *, ...)' [-Werror,-Wimplicit-function-declaration]
printf("%d", in6addr_any.s6_addr[16]);
^
conftest.c:197:1: note: include the header <stdio.h> or explicitly provide
a declaration for 'printf'

ERL-1306
@AquaGeek
Copy link
Contributor Author

Rebased onto maint

@AquaGeek AquaGeek changed the base branch from master to maint July 10, 2020 16:45
@bmk bmk added the testing currently being tested, tag is used by OTP internal CI label Jul 13, 2020
@bmk bmk merged commit 4b0467c into erlang:maint Jul 27, 2020
@bmk
Copy link
Contributor

bmk commented Jul 27, 2020

Merged -> maint -> master

@AquaGeek AquaGeek deleted the missing-includes branch July 28, 2020 23:17
@claui claui mentioned this pull request Sep 1, 2020
Closed
9 tasks
@gromgit gromgit mentioned this pull request Feb 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fix team:VM Assigned to OTP team VM testing currently being tested, tag is used by OTP internal CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AquaGeek @CLAassistant @garazdawi @bmk