Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use grunt.log.error on error, not grutn.warn #106

Closed
mgol opened this issue Sep 30, 2014 · 0 comments · Fixed by #139
Closed

Use grunt.log.error on error, not grutn.warn #106

mgol opened this issue Sep 30, 2014 · 0 comments · Fixed by #139

Comments

@mgol
Copy link

mgol commented Sep 30, 2014

The compiler minify function uses grunt.warn on error:

grunt-angular-templates/tasks/lib/compiler.js

Line 121 in 9aa6b9e

grunt.warn(err + '\n\n' + source + '\n\n');

This makes it extremely hard to find the cause of the issue if html minifier fails.

Please change it to error instead of warn so that stack trace is exposed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@mgol