Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Add support for PHP 7.4 #929

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Enhancement: Add support for PHP 7.4 #929

merged 1 commit into from
Jun 17, 2024

Conversation

localheinz
Copy link
Member

This pull request

  • adds support for PHP 7.4

@localheinz localheinz self-assigned this Jun 17, 2024
@localheinz localheinz requested a review from ergebnis-bot as a code owner June 17, 2024 13:32
@localheinz localheinz force-pushed the feature/php74 branch 2 times, most recently from d6ef5a2 to 0033520 Compare June 17, 2024 13:34
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 92.89%. Comparing base (e44afce) to head (9745500).

Current head 9745500 differs from pull request most recent head be2587e

Please upload reports for the commit be2587e to get more accurate results.

Files Patch % Lines
src/Constructs.php 20.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #929      +/-   ##
============================================
- Coverage     95.15%   92.89%   -2.26%     
- Complexity       50       52       +2     
============================================
  Files             6        6              
  Lines           165      169       +4     
============================================
  Hits            157      157              
- Misses            8       12       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@localheinz localheinz merged commit b928c57 into main Jun 17, 2024
22 checks passed
@localheinz localheinz deleted the feature/php74 branch June 17, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants