Draw column relations #72
Conversation
eralchemy/models.py
Outdated
| self.left_col, | ||
| return '{}{} {}--{} {}{}'.format( | ||
| self.left_table, | ||
| '' if self.left_column is None else '."%s"' % self.left_column, |
There was a problem hiding this comment.
Column names are wrapped in double quotes so that .er files generated prior to these changes can still be parsed correctly. Without some special column delimiter, it would be hard to distinguish the cases for foo.bar, where foo could either be a schema or table name, and bar could be a table or column name.
|
Hi @JosePVB I really like this approach as it make the relationship between classes even clearer ! |
|
This looks very nice - I somehow missed it. Would be good to have this as an option in the future :) |
|
I just merged main into this branch and improved the PR - the resulting run from Also reflecting the improved cardinalities - though it still does not look fully right. Tests are also failing currently |
maurerle
force-pushed
the
draw-column-relations
branch
2 times, most recently
from
77d6ff4 to
7030b3f
Compare
Draw relations between specific columns rather than just between the tables (because when there are multiple relations between two tables, that ends up looking very messy).
maurerle
force-pushed
the
draw-column-relations
branch
from
7030b3f to
8fa193e
Compare
This PR takes advantage of Graphviz support for the PORT attribute on HTML-like labels, to draw the relationships between the specific columns in tables, as opposed to arbitrarily linking the tables together. See https://www.graphviz.org/doc/info/shapes.html#html for more information.
This PR addresses issue #55. It includes the initial work to support this feature, done by @sersorrel. I then added support for this feature in the Markdown output and updated the existing tests.
Below is an example of the what the newsmeme ER diagram looks like with these changes.