Bazefetcher source #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jokva
approved these changes
Oct 4, 2018
camille/source/bazefetcher.py
Outdated
|
|
||
|
|
||
| def _read_json_gz(fn): | ||
| with gzip.GzipFile(fn, 'r') as f: |
camille/source/bazefetcher.py
Outdated
| raise ValueError('{} is not a directory'.format(root)) | ||
|
|
||
| if not isinstance(tzinfo, datetime.tzinfo): | ||
| raise ValueError('tzinfo must be instance of datetime.tzinfo') |
There was a problem hiding this comment.
Maybe let pandas itself figure out if it accepts tzinfo or not.
camille/source/bazefetcher.py
Outdated
| raise ValueError( | ||
| 'start_date and end_date parameters must be of type date') | ||
|
|
||
| if not start_date.tzinfo or not end_date.tzinfo: |
| @@ -0,0 +1,73 @@ | |||
| #!/usr/bin/env python | |||
JensGM
force-pushed
the
bazefetcher-source
branch
3 times, most recently
from
2c8af86 to
7f49fcc
Compare
sveinung-r
approved these changes
Oct 5, 2018
camille/source/bazefetcher.py
Outdated
| # File names are on the form: | ||
| # |- start_date ----------| |- end_date ------------| | ||
| # tag_YYYY-MM-DDTHH.MM.SS+HH.MM_YYYY-MM-DDTHH.MM.SS+HH.MM.json.gz | ||
| date_str = fn[len(tag)+1:-34] # Slice out the start date |
There was a problem hiding this comment.
Perhaps better to split on underscore?
tests/source/test_bazefetcher.py
Outdated
| def test_bazefetcher(): | ||
| tag2 = bazefield('installation-04-tag-2', start_date, end_date) | ||
| assert (1.100000e+32 < tag2).all() | ||
| assert (tag2 < 1.300000e+32).all() |
JensGM
force-pushed
the
bazefetcher-source
branch
10 times, most recently
from
144be10 to
ad25cad
Compare
Add bazefetcher source function that reads baze tags from files emitted from bazefetcher
JensGM
force-pushed
the
bazefetcher-source
branch
from
ad25cad to
77ed9fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.