Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TagNotFoundError for tag misses in Bazefetcher #199

Merged
merged 1 commit into from
Mar 17, 2020

Conversation

jokva
Copy link

@jokva jokva commented Mar 12, 2020

Being able to detect and recover from missing tags is quite useful for
downstream users working with multiple similar-but-not-quite data
sources. By adding TagNotFoundError, users can mechanically determine if
this is a soft input error (missing tags) that can be recovered from, or
more severe errors that require aborts.

Being able to detect and recover from missing tags is quite useful for
downstream users working with multiple similar-but-not-quite data
sources. By adding TagNotFoundError, users can mechanically determine if
this is a soft input error (missing tags) that can be recovered from, or
more severe errors that require aborts.
Copy link
Contributor

@JensGM JensGM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@jokva jokva merged commit 076f050 into equinor:master Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants