Feature missing reference dates #64
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved the whole observations block to have all required variables assigned before
We need the "group" column for internal processing. Maybe we should use a more seldom keyword.
…ctation Feature cumulative sum expectation
Replace group with .group
model description clarifications
This was referenced Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP draft pull request for the missing reference date feature. It implements only the absolute minimum to get a running model, i.e. the preprocessing and the minimal running version of the stan model. No postprocessing yet. I have tested the model with simulated data (see vignette draft in extra dev branch "missing_reference_vignette_wip") and it seems to be working fine. I will add a couple of comments to the coding decisions and add remarks on currently missing extensions that are planned for the MVP.