-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: interactions in random effects #169
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #169 +/- ##
==========================================
Coverage ? 88.33%
==========================================
Files ? 14
Lines ? 1363
Branches ? 0
==========================================
Hits ? 1204
Misses ? 159
Partials ? 0
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@epinowcast/developers if anyone has time to review this that would be appreciated. There will be another formula based PR coming shortly to support optional intercepts needed by #152. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (self-review)
…169 + shorten enw_formula test snapshots
This PR adds support for interactions on the right-hand side of random effects (i.e
(1 + month | day_of_week:age_group)
. This should result in a model with an independent random effect for each age group on the day of the week and random slopes on the month drawn from separate hyper distributions for each age group.This feature is motivated by #152 where we need to be able to specify independent random effects for each group easily in order to reproduce the current default model. There may also be other use cases in the future.
Potentially this syntax is not ideal and/or there are other work around to this feature that I am not aware of.
I have added:
enw_formula
showcasing this functionalityenw_formula
that produces a snapshot. I have confirmed this snapshot has the desired design matrix structure.I have also checked that none of the other functionality has been impacted by reviewing our other tests.
To test out the new functionality see below: