Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename group variable to be more unique #99

Closed
Tracked by #92
seabbs opened this issue Jul 5, 2022 · 1 comment · Fixed by #102
Closed
Tracked by #92

Rename group variable to be more unique #99

seabbs opened this issue Jul 5, 2022 · 1 comment · Fixed by #102
Labels
enhancement New feature or request help wanted Extra attention is needed high-priority

Comments

@seabbs
Copy link
Collaborator

seabbs commented Jul 5, 2022 •
edited
Loading

group and old_group may not be unique in users data. It is sensible to rename these in order to try and avoid this. As this is a breaking change ideally it should form part of the 0.1.0 release. As @sbfnk suggests .group seems like a good choice.

https://github.com/epiforecasts/epinowcast/blob/a48ae0a9ee0652d8b1ffbf6220484ec9c1de2114/R/preprocess.R#L352

I'd suggest .group and .old_group as column names to avoid conflict.

Originally posted by @sbfnk in #64 (comment)
@seabbs seabbs added enhancement New feature or request help wanted Extra attention is needed high-priority labels Jul 5, 2022
This was referenced Jul 5, 2022
Closed
Closed
adrian-lison added a commit that referenced this issue Jul 6, 2022
@adrian-lison
Streamline groups
27fd0e7 
Solving #99 (rename group variable to be more unique) for the preprocessing functions touched by this PR
@adrian-lison adrian-lison mentioned this issue Jul 6, 2022
Merged
@adrian-lison adrian-lison linked a pull request Jul 6, 2022 that will close this issue
Replace group with .group #102
Merged
@seabbs
Copy link
Collaborator Author

seabbs commented Jul 7, 2022

Done by @adrian-lison in #102

@seabbs seabbs closed this as completed Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed high-priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace group with .group epinowcast/epinowcast
1 participant
@seabbs