Fix notes #34
Merged
Fix notes #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: There are ::: calls to the package's namespace in its code. A package almost never needs to use ::: for its own objects: ‘mappings’
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very exciting PR fixing 2 notes flagged in
devtools::check():There are ::: calls to the package's namespace in its code. A package almost never needs to use ::: for its own objects: ‘mappings’
download_trust_data: no visible binding for global variable ‘data’
download_trust_data: no visible binding for global variable ‘nhs_region’
download_trust_data: no visible binding for global variable ‘org_code’
get_admissions: no visible binding for global variable ‘var_name’
get_admissions: no visible binding for global variable ‘data’
get_admissions: no visible binding for global variable ‘org_code’
get_admissions: no visible binding for global variable ‘value’
get_admissions: no visible binding for global variable ‘trust_code’
get_admissions: no visible binding for global variable ‘trust_name’
get_admissions: no visible binding for global variable ‘var’
get_admissions: no visible binding for global variable ‘p_trust’
get_admissions: no visible binding for global variable ‘geo_code’
get_admissions: no visible binding for global variable ‘geo_name’
get_admissions: no visible binding for global variable ‘new_adm’
get_names: no visible binding for global variable ‘trust_code’
get_names: no visible binding for global variable ‘trust_name’
get_names: no visible binding for global variable ‘geo_code’
get_names: no visible binding for global variable ‘geo_name’
get_names: no visible binding for global variable ‘p_trust’
get_names: no visible binding for global variable ‘p_geo’
load_mapping: no visible binding for global variable ‘map_source’
load_mapping: no visible binding for global variable ‘map_level’
summarise_mapping: no visible binding for global variable ‘trust_code’
summarise_mapping: no visible binding for global variable ‘trust_name’
summarise_mapping: no visible binding for global variable ‘geo_code’
summarise_mapping: no visible binding for global variable ‘geo_name’
summarise_mapping: no visible binding for global variable ‘p_trust’
summarise_mapping: no visible binding for global variable ‘p’
summarise_mapping: no visible binding for global variable ‘p_geo’
Undefined global functions or variables: data geo_code geo_name map_level map_source new_adm nhs_region org_code p p_geo p_trust trust_code trust_name value var var_name
Consider adding importFrom("stats", "var") importFrom("utils", "data") to your NAMESPACE file.