Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix R-CMD-check #32

Merged
merged 1 commit into from
Sep 22, 2022
Merged

Fix R-CMD-check #32

merged 1 commit into from
Sep 22, 2022

Conversation

sophiemeakin
Copy link
Collaborator

  • Error: Error: R CMD check found WARNINGs
  • Warning: found non-ASCII strings (in england_ltla_shape and england_utla_shape)
  • Non-ASCII strings were degree symbol
  • Fixed by replacing them with the corresponding ASCII code (thanks @jengelaere non-ASCII string in CRS r-spatial/sf#1341)
  • Also replace library() with pacman::p_load()

@sophiemeakin
Fix R-CMD-check
75cf1a7 
* Error: Error: R CMD check found WARNINGs
* Warning: found non-ASCII strings (in england_ltla_shape and england_utla_shape)
* Non-ASCII strings were degree symbol
* Fixed by replacing them with the corresponding ASCII code (thanks @jengelaere r-spatial/sf#1341)
* Also replace library() with pacman::p_load()
@sophiemeakin sophiemeakin requested a review from seabbs September 22, 2022 14:51
@sophiemeakin
Copy link
Collaborator Author

All fixed 🎉 🥳 🏆

@sophiemeakin sophiemeakin merged commit bd66ebb into main Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seabbs seabbs Awaiting requested review from seabbs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sophiemeakin