Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Random improvements #877

Merged
merged 8 commits into from
Apr 19, 2023
Merged

Random improvements #877

merged 8 commits into from
Apr 19, 2023

Conversation

epi052
Copy link
Owner

@epi052 epi052 commented Apr 19, 2023

Landing a Pull Request (PR)

Long form explanations of most of the items below can be found in the CONTRIBUTING guide.

Branching checklist

  • There is an issue associated with your PR (bug, feature, etc.. if not, create one)
  • Your PR description references the associated issue (i.e. fixes #123456)
  • Code is in its own branch
  • Branch name is related to the PR contents
  • PR targets main

Static analysis checks

  • All rust files are formatted using cargo fmt
  • All clippy checks pass when running cargo clippy --all-targets --all-features -- -D warnings -A clippy::mutex-atomic
  • All existing tests pass

Documentation

Additional Tests

  • New code is unit tested
  • New code is integration tested, as needed
  • New tests pass

@codecov
Copy link

codecov bot commented Apr 19, 2023 •
edited
Loading

Codecov Report

Patch coverage: 88.09% and project coverage change: +0.09 🎉

Comparison is base (e77c131) 92.43% compared to head (692db93) 92.52%.

❗ Current head 692db93 differs from pull request most recent head 3378246. Consider uploading reports for the commit 3378246 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #877      +/-   ##
==========================================
+ Coverage   92.43%   92.52%   +0.09%     
==========================================
  Files          63       63              
  Lines       11499    11585      +86     
==========================================
+ Hits        10629    10719      +90     
+ Misses        870      866       -4
Impacted Files Coverage Δ
src/main.rs 93.05% <ø> (-0.02%) ⬇️
src/scan_manager/scan_container.rs 61.53% <0.00%> (ø)
src/extractor/container.rs 87.96% <80.32%> (-0.48%) ⬇️
src/heuristics.rs 88.04% <89.28%> (-0.08%) ⬇️
src/scanner/requester.rs 97.52% <90.00%> (-0.23%) ⬇️
src/progress.rs 97.29% <98.00%> (-0.21%) ⬇️
src/event_handlers/outputs.rs 95.66% <100.00%> (-0.09%) ⬇️
src/event_handlers/scans.rs 89.53% <100.00%> (+3.97%) ⬆️
src/event_handlers/statistics.rs 99.03% <100.00%> (ø)
src/extractor/tests.rs 99.00% <100.00%> (ø)
... and 5 more

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@epi052 epi052 merged commit 02ef6d7 into main Apr 19, 2023
@epi052 epi052 deleted the update-indicatif-finally branch April 19, 2023 12:59
@ZhongRuoyu ZhongRuoyu mentioned this pull request Apr 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@epi052