Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove scan info from update check #1033

Merged
merged 2 commits into from
Nov 25, 2023

Conversation

epi052
Copy link
Owner

@epi052 epi052 commented Nov 25, 2023

closes #1031

Landing a Pull Request (PR)

Long form explanations of most of the items below can be found in the CONTRIBUTING guide.

Branching checklist

  • There is an issue associated with your PR (bug, feature, etc.. if not, create one)
  • Your PR description references the associated issue (i.e. fixes #123456)
  • Code is in its own branch
  • Branch name is related to the PR contents
  • PR targets main

Static analysis checks

  • All rust files are formatted using cargo fmt
  • All clippy checks pass when running cargo clippy --all-targets --all-features -- -D warnings -A clippy::mutex-atomic
  • All existing tests pass

Documentation

Additional Tests

  • New code is unit tested
  • New code is integration tested, as needed
  • New tests pass

Copy link

codecov bot commented Nov 25, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (55c6735) 92.39% compared to head (b5ffe16) 92.31%.
Report is 4 commits behind head on main.

Files Patch % Lines
src/client.rs 63.63% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1033      +/-   ##
==========================================
- Coverage   92.39%   92.31%   -0.08%     
==========================================
  Files          63       63              
  Lines       12078    12069       -9     
==========================================
- Hits        11159    11142      -17     
- Misses        919      927       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@epi052 epi052 merged commit a714825 into main Nov 25, 2023
13 of 15 checks passed
@epi052 epi052 deleted the 1031-remove-scan-info-from-update-check branch November 25, 2023 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Feroxbuster sends specified cookie or header to Github when checking for latest release
1 participant