Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] thread 'tokio-runtime-worker' panicked at 'called Option::unwrap() on a None value #905

Closed
ktecv2000 opened this issue May 26, 2023 · 6 comments · Fixed by #936
Closed
Labels
bug Something isn't working pinned

Comments

@ktecv2000
Copy link

I think it's similar to issue #563, and I've encountered this issue on version 2.10.0 and 2.9.1

I try to remove other unrelated argument as much as possible and this is the shortest command I could possibly reproduce this issue

feroxbuster -u "<myurl>" -w raft-medium-files-lowercase.txt --collect-words

Error:
thread 'tokio-runtime-worker' panicked at 'called Option::unwrap() on a None value', src/nlp/document.rs:51:14

It might be related to --collect-words option

@ktecv2000 ktecv2000 added the bug Something isn't working label May 26, 2023
@epi052
Copy link
Owner

epi052 commented May 26, 2023

it's just a place where i used unwrap, thinking it would always be valid, but it isnt 🙃

a quick look at the code in question makes me think the page you're requesting doesn't have a <body> tag

@ktecv2000
Copy link
Author

ktecv2000 commented May 30, 2023

After debugging my ass hell out I found which page is blamed for

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Frameset//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-frameset.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1" />
<title>Export to PDF</title>
<script type="text/javascript">
window.status='Export to PDF';
</script>
</head>

<frameset rows="0,*"" frameborder="NO" border="0" framespacing="0">
 <frame src="" name="topFrame" id="topFrame" title="topFrame" />
 <frame src="http://redacted.com/capture/pdf.php?url=" name="mainFrame" id="mainFrame" title="mainFrame" />
</frameset>
<noframes><body>
</body>
</noframes></html>

looks like there's indeed a <body> , I'm not sure why this broke the fuzzer

@epi052
Copy link
Owner

epi052 commented May 30, 2023

ok, the html parser we use doesn't recognize the body tag because it's within the <noframes> tag

HTML <noframes> tag is used to contain an alternative text to display if the browser does not support the content. It will only work, if the browser does not support the frame else, it will be ignored by the browser.

i'll update ferox to properly handle cases like this. it'll be in the next release.

Thanks for tracking this down!

@stale
Copy link

stale bot commented Jun 17, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 17, 2023
@epi052 epi052 pinned this issue Jun 24, 2023
@epi052 epi052 unpinned this issue Jun 24, 2023
@stale stale bot removed the stale label Jun 24, 2023
@stale stale bot removed the stale label Jun 24, 2023
@epi052
Copy link
Owner

epi052 commented Jul 11, 2023

@all-contributors add @ktecv2000 for bugs

@allcontributors
Copy link
Contributor

@epi052

I've put up a pull request to add @ktecv2000! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working pinned
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants