-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Features/item flags #319
Merged
Merged
Features/item flags #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pthom
added a commit
to pthom/implot
that referenced
this pull request
Sep 7, 2022
…d "long double" (Fixes epezent#319) - INSTANTIATE_FOR_NUMERIC_TYPES is a macro which instantiates templated plotting functions for numeric types. This macro helps reduce some boilerplate code for template functions instantiations. - Added optional support for more numeric types: The numeric type list does not include "long", "unsigned long" and "long double". Most of the time, it is not an issue when linking statically. However, when linking dynamically, issues related to undefined functions can arise: although those types might have the same size, they are considered separate. define IMPLOT_INSTANTIATE_ALL_NUMERIC_TYPES) in order to define versions for those types In this case, the compilation time for this specific file will be 33% longer Notes about numeric types : even if "long double" and "double" might occupy the same size, they are not complete synonyms, and it is legal to define overloads for both double and long double. see https://godbolt.org/z/ae71P7rqG (long double vs double, example with MSVC 64 bits) and https://godbolt.org/z/1KWv5re7q (long long vs long, example with GCC 64 bits)
pthom
added a commit
to pthom/implot
that referenced
this pull request
Sep 7, 2022
…d "long double" (Fixes epezent#319) - INSTANTIATE_FOR_NUMERIC_TYPES is a macro which instantiates templated plotting functions for numeric types. This macro helps reduce some boilerplate code for template functions instantiations. - Added optional support for more numeric types: The numeric type list does not include "long", "unsigned long" and "long double". Most of the time, it is not an issue when linking statically. However, when linking dynamically, issues related to undefined functions can arise: although those types might have the same size, they are considered separate. define IMPLOT_INSTANTIATE_ALL_NUMERIC_TYPES) in order to define versions for those types In this case, the compilation time for this specific file will be 33% longer Notes about numeric types : even if "long double" and "double" might occupy the same size, they are not complete synonyms, and it is legal to define overloads for both double and long double. see https://godbolt.org/z/ae71P7rqG (long double vs double, example with MSVC 64 bits) and https://godbolt.org/z/1KWv5re7q (long long vs long, example with GCC 64 bits)
pthom
added a commit
to pthom/implot
that referenced
this pull request
Sep 7, 2022
…d "long double" (Fixes epezent#319) - INSTANTIATE_FOR_NUMERIC_TYPES is a macro which instantiates templated plotting functions for numeric types. This macro helps reduce some boilerplate code for template functions instantiations. - Added optional support for more numeric types: The numeric type list does not include "long", "unsigned long" and "long double". Most of the time, it is not an issue when linking statically. However, when linking dynamically, issues related to undefined functions can arise: although those types might have the same size, they are considered separate. define IMPLOT_INSTANTIATE_ALL_NUMERIC_TYPES) in order to define versions for those types In this case, the compilation time for this specific file will be 33% longer Notes about numeric types "synonyms": Even if "long double" and "double" might occupy the same size, they are not complete synonyms, and it is legal to define overloads for both double and long double. On some platforms, "unsigned long" might be the same size as "unsigned long long", but it is nonetheless a separate type: see https://godbolt.org/z/1KWv5re7q (example with GCC 64 bits) On some other platforms, "long double" might be the same size as "double", but it is nonetheless a separate type: see https://godbolt.org/z/ae71P7rqG (example with MSVC 64 bits)
pthom
added a commit
to pthom/implot
that referenced
this pull request
Sep 7, 2022
…ix epezent#319) - INSTANTIATE_FOR_NUMERIC_TYPES is a macro which instantiates templated plotting functions for numeric types. This macro helps reduce some boilerplate code for template functions instantiations. - Added optional support for more numeric types (long and long double) The numeric type list does not include "long", "unsigned long" and "long double". Most of the time, it is not an issue when linking statically. However, when linking dynamically, issues related to undefined functions can arise: although those types might have the same size, they are considered separate. define IMPLOT_INSTANTIATE_ALL_NUMERIC_TYPES) in order to define versions for those types In this case, the compilation time for this specific file will be 33% longer - implot_internal.h / ImMean and ImStdDev: added cast to double (suppress MSVC warning about downcasting) - Notes about numeric types "synonyms": Even if "long double" and "double" might occupy the same size, they are not complete synonyms, and it is legal to define overloads for both double and long double. On some platforms, "unsigned long" might be the same size as "unsigned long long", but it is nonetheless a separate type: see https://godbolt.org/z/1KWv5re7q (example with GCC 64 bits) On some other platforms, "long double" might be the same size as "double", but it is nonetheless a separate type: see https://godbolt.org/z/ae71P7rqG (example with MSVC 64 bits)
epezent
pushed a commit
that referenced
this pull request
Sep 11, 2022
#319) (#397) * implot_items: INSTANTIATE_FOR_NUMERIC_TYPES / add long & long double (Fix #319) - INSTANTIATE_FOR_NUMERIC_TYPES is a macro which instantiates templated plotting functions for numeric types. This macro helps reduce some boilerplate code for template functions instantiations. - Added optional support for more numeric types (long and long double) The numeric type list does not include "long", "unsigned long" and "long double". Most of the time, it is not an issue when linking statically. However, when linking dynamically, issues related to undefined functions can arise: although those types might have the same size, they are considered separate. define IMPLOT_INSTANTIATE_ALL_NUMERIC_TYPES) in order to define versions for those types In this case, the compilation time for this specific file will be 33% longer - implot_internal.h / ImMean and ImStdDev: added cast to double (suppress MSVC warning about downcasting) - Notes about numeric types "synonyms": Even if "long double" and "double" might occupy the same size, they are not complete synonyms, and it is legal to define overloads for both double and long double. On some platforms, "unsigned long" might be the same size as "unsigned long long", but it is nonetheless a separate type: see https://godbolt.org/z/1KWv5re7q (example with GCC 64 bits) On some other platforms, "long double" might be the same size as "double", but it is nonetheless a separate type: see https://godbolt.org/z/ae71P7rqG (example with MSVC 64 bits) * IMPLOT_INSTANTIATE_ALL_NUMERIC_TYPES: disabled by default * uppercase template instantiatation macros & group them * implot_items.cpp: reword comments on IMPLOT_INSTANTIATE_ALL_NUMERIC_TYPES * README.md: mention compile-time option IMPLOT_INSTANTIATE_ALL_NUMERIC_TYPES * Github CI: IMPLOT_INSTANTIATE_ALL_NUMERIC_TYPES=1
szym-nuro
added a commit
to szym-nuro/implot
that referenced
this pull request
Nov 13, 2023
Ben1138
pushed a commit
to Ben1138/implot
that referenced
this pull request
Oct 2, 2024
* add PlotBarGroups and layout some plans for flags * exprimentin * item flags added to each plotter * rendering templates * rendering templates * item flags and axis scales * item flags * template markers * markers * benching * buffer * inline adjust * inline fix * dunno * fix some todos * tickers * clean up * update TODO * update breaking changes * demo cleanup * remove TODO label * header cleanup
Ben1138
pushed a commit
to Ben1138/implot
that referenced
this pull request
Oct 2, 2024
epezent#319) (epezent#397) * implot_items: INSTANTIATE_FOR_NUMERIC_TYPES / add long & long double (Fix epezent#319) - INSTANTIATE_FOR_NUMERIC_TYPES is a macro which instantiates templated plotting functions for numeric types. This macro helps reduce some boilerplate code for template functions instantiations. - Added optional support for more numeric types (long and long double) The numeric type list does not include "long", "unsigned long" and "long double". Most of the time, it is not an issue when linking statically. However, when linking dynamically, issues related to undefined functions can arise: although those types might have the same size, they are considered separate. define IMPLOT_INSTANTIATE_ALL_NUMERIC_TYPES) in order to define versions for those types In this case, the compilation time for this specific file will be 33% longer - implot_internal.h / ImMean and ImStdDev: added cast to double (suppress MSVC warning about downcasting) - Notes about numeric types "synonyms": Even if "long double" and "double" might occupy the same size, they are not complete synonyms, and it is legal to define overloads for both double and long double. On some platforms, "unsigned long" might be the same size as "unsigned long long", but it is nonetheless a separate type: see https://godbolt.org/z/1KWv5re7q (example with GCC 64 bits) On some other platforms, "long double" might be the same size as "double", but it is nonetheless a separate type: see https://godbolt.org/z/ae71P7rqG (example with MSVC 64 bits) * IMPLOT_INSTANTIATE_ALL_NUMERIC_TYPES: disabled by default * uppercase template instantiatation macros & group them * implot_items.cpp: reword comments on IMPLOT_INSTANTIATE_ALL_NUMERIC_TYPES * README.md: mention compile-time option IMPLOT_INSTANTIATE_ALL_NUMERIC_TYPES * Github CI: IMPLOT_INSTANTIATE_ALL_NUMERIC_TYPES=1
epezent
pushed a commit
that referenced
this pull request
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #370