Issue 2721 Storage Lifecycle Service: move config to region #2830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s: bucket cred settings -> region cred custom settings -> region cred settings -> default aws cred chain
SilinPavel
force-pushed
the
issue_2721_sls_config_to_region_settings
branch
from
341611a to
a1333da
Compare
mzueva
approved these changes
Sep 14, 2022
mzueva
pushed a commit
that referenced
this pull request
Jan 18, 2023
* issue 2721 Move sls config to cp region settings WIP * issue 2721 SLS properties to region model * issue 2721 Storage Lifecycle Service: use cloud regions * issue 2721 Storage Lifecycle Service: common auth flow for aws buckets: bucket cred settings -> region cred custom settings -> region cred settings -> default aws cred chain * issue 2721 clean up * issue 2721 Move sls config to cp region settings - refactor * issue 2721 SLS config to region: Remove redundant annotation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves config for SLS to region settings (to be able to override such props for each region)
Also cloud credentials retrieval chain was changed to: Storage credentials settings -> Region credentials settings -> Default credential settings