Issue #2574: pipe storage cp shall start data upload before traversing full source hierarchy (S3 provider) #2597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g full source hierarchy (WIP)
…g full source hierarchy - s3 ls (WIP)
…g full source hierarchy - async batch collection for cp/mv operation
…g full source hierarchy - cleanups
…ipe-storage-cp # Conflicts: # pipe-cli/src/utilities/datastorage_operations.py
tcibinan
reviewed
Apr 12, 2022
…g full source hierarchy - refactor cp/mv paging
…g full source hierarchy - refactor cp/mv paging
tcibinan
approved these changes
Apr 12, 2022
…_2574-batch-pipe-storage-cp # Conflicts: # pipe-cli/src/utilities/datastorage_operations.py # pipe-cli/src/utilities/storage/s3.py
…_2574-batch-pipe-storage-cp
…g full source hierarchy (S3 provider) - cleanups
…g full source hierarchy (S3 provider) - async batch
…g full source hierarchy (S3 provider) - disable async batch by default
…g full source hierarchy (S3 provider) - cleanup
…g full source hierarchy (S3 provider) - cleanup
…g full source hierarchy (S3 provider) - cleanup
…g full source hierarchy (S3 provider) - cleanup
…g full source hierarchy (S3 provider) - support local paths
…g full source hierarchy (S3 provider) - cleanup
…g full source hierarchy (S3 provider) - cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current PR provides implementation for issue #2574
pipe storage cp/mvoperations - this feature enables for:--verify-destinationshall not be enabled (since this option required full source listing)--file-listshall not be enabledpipe storage lsoperation - full listing enables for:--recursiveoptions shall be specified--show_versionsshall not be specified--pagesize limit shall not be specifiedpipe storage rmoperations - added page size support for S3 providerbatch size can be tuned via
CP_CLI_STORAGE_BATCH_SIZEenvironment variable (default: 1000)CP_CLI_STORAGE_ASYNC_BATCH_ENABLE=[True|False]- enables asynchronous batch transfer - listing operation performs in separate thread (default: False)