Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HCS images] Ability to lock ranges of the channels #2528

Open
NShaforostov opened this issue Feb 24, 2022 · 5 comments
Open

[HCS images] Ability to lock ranges of the channels #2528

NShaforostov opened this issue Feb 24, 2022 · 5 comments
Labels
goal/charlie 🐟 kind/enhancement New feature or request state/has-case Issues that have test-cases state/verify Issues that are already addressed and require validation sys/gui Issues related to the web gui

Comments

@NShaforostov
Copy link
Collaborator

Background

Once the #2489 is implemented, users can preview HCS images, selecting plate, well, field, etc. to view.
Also, they can configure the contrast for any of the available channel of the image. Currently, value of the channel contrast range is being set automatically (autofluorescence regimen, for the best displaying). This happens every time when user select another field or another well, or something else. But in some cases, user may want to "lock" the selected contrast range for the channel - so that selecting another field will not change that range.
We should add such ability.

Approach

Add a new checkbox to the Settings panel of the preview pop-up, e.g.:
image

By click this checkbox, current shown ranges for each channel and their extreme values should be fixed:

  • if user will change the field, for example, then the contrast settings for channels shall not be changed and shall remain the same (this shall apply to both - channel boundary values (min and max) and the configured range). I.e. if for the channel1 boundaries were from 100 to 2000 and selected range from 150 to 370 - all these values should be applied for the channel1 for any other selected field
  • channel sliders should become disabled
    image
    And when the user changes the field, for example, then channels contrast settings shall remain:
    image

If user unticks the "Lock" checkbox - for the current shown field:

  • autofluorescence regimen shall be enabled again and channels contrast settings shall be autoconfigured
  • channel sliders should become enabled
    image
@NShaforostov NShaforostov added kind/enhancement New feature or request goal/charlie 🐟 sys/gui Issues related to the web gui labels Feb 24, 2022
rodichenko added a commit that referenced this issue Mar 3, 2022
* GUI HCS Image: add lock channels control

* [HCS images] Ability to lock ranges of the channels (#2528)

Co-authored-by: Aleksandr Gorodetskii <gorod2004@gmail.com>
rodichenko added a commit that referenced this issue Mar 3, 2022
@rodichenko
Copy link
Contributor

@sidoruka @NShaforostov Persist channels state option implemented (#2542)

@rodichenko rodichenko added the state/verify Issues that are already addressed and require validation label Mar 3, 2022
@maryvictol
Copy link
Collaborator

@rodichenko
Bug:
Channels settings aren't kept at changing view from Well view to Field view or back.

rodichenko added a commit that referenced this issue Sep 13, 2022
@rodichenko
Copy link
Contributor

Channels settings aren't kept at changing view from Well view to Field view or back.

40915c3 should fix that

@maryvictol
Copy link
Collaborator

Channels settings aren't kept at changing view from Well view to Field view or back.

40915c3 should fix that

Verified as fixed

@maryvictol
Copy link
Collaborator

Test case was created by #2786 and located here.

@maryvictol maryvictol added the state/has-case Issues that have test-cases label Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
goal/charlie 🐟 kind/enhancement New feature or request state/has-case Issues that have test-cases state/verify Issues that are already addressed and require validation sys/gui Issues related to the web gui
Projects
None yet
Development

No branches or pull requests

3 participants