Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Custom" capabilities shall allow to configure job parameters #2295

Closed
sidoruka opened this issue Nov 10, 2021 · 6 comments
Closed

"Custom" capabilities shall allow to configure job parameters #2295

sidoruka opened this issue Nov 10, 2021 · 6 comments
Assignees
@rodichenko
Labels
goal/dorado ✨ kind/enhancement New feature or request state/has-case Issues that have test-cases state/has-doc Issues that have documentation state/has-e2e Issues that are have e2e tests automation state/verify Issues that are already addressed and require validation sys/core Issues related to core functionality (API, VM management, ...) sys/gui Issues related to the web gui
Milestone
v0.17

Comments

@sidoruka
Copy link
Contributor

sidoruka commented Nov 10, 2021 •
edited
Loading

"Custom" capabilities (#2234 ) shall also allow to set run parameters for a job.

I.e. administrator shall be able to add (optionally) params field to the capability - list of key/values. Each of those keys and values shall be set as the parameters for a job.

{
  "capability1": {
    "description": "Some text goes here",
    "commands": [
      "cmd1",
      "cmd2"
    ],
    "params": {
      "MY_PARAM1": "MY_VALUE1",
      "MY_PARAM2": "MY_VALUE2"
    }
  },
  "capability2": {
    "description": "Another text goes here",
    "commands": [
      "cmd1"
    ]
  }
}
@sidoruka sidoruka added kind/enhancement New feature or request sys/gui Issues related to the web gui sys/core Issues related to core functionality (API, VM management, ...) goal/dorado ✨ labels Nov 10, 2021
@sidoruka sidoruka added this to the v0.17 milestone Nov 10, 2021
@sidoruka
Copy link
Contributor Author

@rodichenko please backport to release/0.16

rodichenko added a commit that referenced this issue Nov 10, 2021
@rodichenko
"Custom" capabilities shall allow to configure job parameters (#2295)…
d3f0d20 
… - custom capabilities parameters are applied to the job parameters
rodichenko added a commit that referenced this issue Nov 10, 2021
@rodichenko
"Custom" capabilities shall allow to configure job parameters (#2295)…
3d0841f 
… - custom capabilities parameters are applied to the job parameters, backported to release/0.16
@rodichenko
Copy link
Contributor

@sidoruka implemented (d3f0d20), backported to release/0.16 (3d0841f)

@rodichenko rodichenko added the state/verify Issues that are already addressed and require validation label Nov 10, 2021
sidoruka pushed a commit that referenced this issue Nov 10, 2021
@rodichenko @sidoruka
"Custom" capabilities shall allow to configure job parameters (#2295)…
3b1117b 
… - custom capabilities parameters are applied to the job parameters, backported to release/0.16

(cherry picked from commit 3d0841f)
sidoruka pushed a commit that referenced this issue Nov 12, 2021
@rodichenko @sidoruka
"Custom" capabilities shall allow to configure job parameters (#2295)…
8d20469 
… - custom capabilities parameters are applied to the job parameters, backported to release/0.16

(cherry picked from commit 3d0841f)
(cherry picked from commit 3b1117b)
@maryvictol maryvictol mentioned this issue Nov 15, 2021
Merged
@sidoruka sidoruka mentioned this issue Nov 18, 2021
Closed
kamyshova pushed a commit that referenced this issue Nov 22, 2021
@maryvictol
Gui custom capabilities testcases (#2287)
ac2bd7b 
Testcases and tests for "Custom" capabilities implementation #2234 and #2295
@NShaforostov
Copy link
Collaborator

NShaforostov commented Nov 25, 2021 •
edited
Loading

Test case was created by #2287 and located here.

@NShaforostov NShaforostov added the state/has-case Issues that have test-cases label Nov 25, 2021
@NShaforostov
Copy link
Collaborator

e2e-tests were implemented via #2287.

@NShaforostov
Copy link
Collaborator

Daily e2e-tests results are located and updated here (for AWS).

@NShaforostov NShaforostov added the state/has-e2e Issues that are have e2e tests automation label Nov 25, 2021
NShaforostov added a commit that referenced this issue Mar 5, 2022
@NShaforostov
(Issue #2234, #2295) 'Custom Run capabilities' doc was added
d16529a
@NShaforostov NShaforostov mentioned this issue Mar 5, 2022
Merged
NShaforostov added a commit that referenced this issue Nov 7, 2022
@NShaforostov
Docs were added: 'Sensitive storages' (#1036), 'Tool image history' (#…
7f82a98 
…1140), 'Custom run capabilities' (#2234, #2295, #2323), 'Storage Lifecycle' (#2721, #2759)
NShaforostov added a commit that referenced this issue Nov 7, 2022
@NShaforostov
Docs and RN 0.17 were added/updated (#2547)
b387e90 
- 'Sensitive storages' (#1036)
- 'Tool image history' (#1140)
- 'Custom run capabilities' (#2234, #2295, #2323)
- 'Storage Lifecycle' (#2721, #2759)
@NShaforostov
Copy link
Collaborator

Docs were added via #2547 and can be found here.

@NShaforostov NShaforostov added the state/has-doc Issues that have documentation label Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rodichenko rodichenko

Labels
goal/dorado ✨ kind/enhancement New feature or request state/has-case Issues that have test-cases state/has-doc Issues that have documentation state/has-e2e Issues that are have e2e tests automation state/verify Issues that are already addressed and require validation sys/core Issues related to core functionality (API, VM management, ...) sys/gui Issues related to the web gui
Projects
None yet
Milestone
v0.17
Development

No branches or pull requests
3 participants
@rodichenko @sidoruka @NShaforostov