Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support ingress.tls.hosts templating in dial-extension helm chart #86

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

nepalevov
Copy link
Contributor

@nepalevov nepalevov commented Oct 21, 2024

Applicable issues

  • fixes #

Description of changes

Add the ability to template ingress.tls.hosts values, preserving the ability to mention hosts that differ from ingress.hosts, e.g.:

global:
  url: "example.com"

ingress:
  enabled: true
  ingressClassName: nginx
  annotations:
    cert-manager.io/cluster-issuer: "letsencrypt-production"
  hosts:
    - "themes-{{ .Values.global.url }}"
  tls:
    - secretName: "themes-tls-secret"
      hosts:
        - "themes-{{ .Values.global.url }}"

Additional information

Testing

Checklist

  • Chart version bumped in Chart.yaml according to semver
  • appVersion bumped in Chart.yaml if it's dial chart and any application version changed
  • Variables are documented in the values.yaml and added to the README.md using helm-docs
  • Title of the pull request follows Conventional Commits specification

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@nepalevov nepalevov self-assigned this Oct 21, 2024
@nepalevov nepalevov requested a review from alexey-ban as a code owner October 21, 2024 18:16
@nepalevov nepalevov changed the title feat: support ingress.tls.hosts templating feat: support ingress.tls.hosts templating in dial-extension helm chart Oct 21, 2024
@nepalevov nepalevov merged commit baee39e into main Oct 21, 2024
4 checks passed
@nepalevov nepalevov deleted the feat-template-ingress-tls-hosts-in-dial-extension branch October 21, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants